From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id C260E1FF0B7 for ; Fri, 02 Oct 2026 14:12:08 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 47D7021681; Fri, 02 Oct 2026 14:12:08 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 02 Oct 2026 14:12:03 +0200 Message-Id: Subject: Re: [PATCH proxmox] fix #7723: network-api: avoid overwriting existing inet6 family method From: "Shan Shaji" To: "Shan Shaji" , X-Mailer: aerc 0.20.0 References: <20260622120658.361868-1-s.shaji@proxmox.com> In-Reply-To: <20260622120658.361868-1-s.shaji@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1790943124108 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.442 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: PRFLESNF3UFRHJZ25627C4Y4IPIHILGK X-Message-ID-Hash: PRFLESNF3UFRHJZ25627C4Y4IPIHILGK X-MailFrom: s.shaji@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: gentle ping, this still applies. On Mon Jun 22, 2026 at 2:06 PM CEST, Shan Shaji wrote: > If the inet6 address family's cidr6/gatway6 values are not present, the > interface.method6 values is mutated with `NetworkConfigMethod::Manual` > even if the interface.method6 already has a value. For example, if > the config method is `auto` then it gets replaced by `Manual` config > method. > > Later, when writing the config file to the interfaces.new file if the > config method is manual and if there are no IPv6 specific attributes > present, then the inet6 stanza gets skipped. > > In order to fix the issue update the condition to only set the config > method to `::Manual` if there is no value present inside the `method6` > property of the interface object. > > Signed-off-by: Shan Shaji > --- > > note: The issue where the UI showed an error has already been fixed > in commit (#973cf333). > > proxmox-network-api/src/api_impl.rs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/proxmox-network-api/src/api_impl.rs b/proxmox-network-api/sr= c/api_impl.rs > index 9d956e2c..ee78a88c 100644 > --- a/proxmox-network-api/src/api_impl.rs > +++ b/proxmox-network-api/src/api_impl.rs > @@ -332,7 +332,7 @@ pub fn update_interface( > > if interface.cidr6.is_some() || interface.gateway6.is_some() { > interface.method6 =3D Some(NetworkConfigMethod::Static); > - } else { > + } else if interface.method6.is_none() { > interface.method6 =3D Some(NetworkConfigMethod::Manual); > } >