From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id F12841FF153 for ; Mon, 22 Jun 2026 14:07:27 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 54615A9DA; Mon, 22 Jun 2026 14:07:27 +0200 (CEST) From: Shan Shaji To: pdm-devel@lists.proxmox.com Subject: [PATCH proxmox] fix #7723: network-api: avoid overwriting existing inet6 family method Date: Mon, 22 Jun 2026 14:06:58 +0200 Message-ID: <20260622120658.361868-1-s.shaji@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1782130033008 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.149 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: EPELAYHNEKWXPG2RIMTOQ6BLVZRIRMOW X-Message-ID-Hash: EPELAYHNEKWXPG2RIMTOQ6BLVZRIRMOW X-MailFrom: s.shaji@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: If the inet6 address family's cidr6/gatway6 values are not present, the interface.method6 values is mutated with `NetworkConfigMethod::Manual` even if the interface.method6 already has a value. For example, if the config method is `auto` then it gets replaced by `Manual` config method. Later, when writing the config file to the interfaces.new file if the config method is manual and if there are no IPv6 specific attributes present, then the inet6 stanza gets skipped. In order to fix the issue update the condition to only set the config method to `::Manual` if there is no value present inside the `method6` property of the interface object. Signed-off-by: Shan Shaji --- note: The issue where the UI showed an error has already been fixed in commit (#973cf333). proxmox-network-api/src/api_impl.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proxmox-network-api/src/api_impl.rs b/proxmox-network-api/src/api_impl.rs index 9d956e2c..ee78a88c 100644 --- a/proxmox-network-api/src/api_impl.rs +++ b/proxmox-network-api/src/api_impl.rs @@ -332,7 +332,7 @@ pub fn update_interface( if interface.cidr6.is_some() || interface.gateway6.is_some() { interface.method6 = Some(NetworkConfigMethod::Static); - } else { + } else if interface.method6.is_none() { interface.method6 = Some(NetworkConfigMethod::Manual); } -- 2.47.3