all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Shannon Sterz" <s.sterz@proxmox.com>, <pdm-devel@lists.proxmox.com>
Subject: Re: [PATCH datacenter-manager 4/4] ui: auto-installer: make the fqdn field a large field
Date: Tue, 26 May 2026 14:22:54 +0200	[thread overview]
Message-ID: <DISLSPSWTTVH.31CXGXWG81NM2@proxmox.com> (raw)
In-Reply-To: <20260526113310.289789-5-s.sterz@proxmox.com>

On Tue May 26, 2026 at 1:33 PM CEST, Shannon Sterz wrote:
> especially with template variables the content of this field can get
> fairly long. also moves the "FQDN from DHCP" and "Pin Network
> Interfaces" around to match.
>
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
>  ui/src/remotes/auto_installer/prepared_answer_form.rs | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/ui/src/remotes/auto_installer/prepared_answer_form.rs b/ui/src/remotes/auto_installer/prepared_answer_form.rs
> index 28f4851..c1d2bab 100644
> --- a/ui/src/remotes/auto_installer/prepared_answer_form.rs
> +++ b/ui/src/remotes/auto_installer/prepared_answer_form.rs
> @@ -323,11 +323,11 @@ pub fn render_network_options_form(
>                  .disabled(use_dhcp_network)
>                  .required(!use_dhcp_network),
>          )
> -        .with_right_field(
> +        .with_field(
>              tr!("FQDN from DHCP"),
>              Checkbox::new().name("use-dhcp-fqdn").default(false),
>          )
> -        .with_right_field(
> +        .with_large_field(
>              tr!("Fully-Qualified Domain Name (FQDN)"),
>              Field::new()
>                  .name("fqdn")
> @@ -346,8 +346,7 @@ pub fn render_network_options_form(
>                  })
>                  .required(!use_dhcp_fqdn),
>          )
> -        .with_right_field("", DisplayField::new().key("dummy"))
> -        .with_right_field(
> +        .with_field(
>              tr!("Pin Network Interfaces"),
>              Checkbox::new()
>                  .name("netif-name-pinning-enabled")

makes sense generally, but after this change the "Network Options" tabs
is a bit weird to look at, since now the network configuration fields
still span half the dialog width, without there being a second column.

Maybe we should use the same proportions as on the first page of the
wizard, so just a single column with broader labels?





  reply	other threads:[~2026-05-26 12:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-26 11:33 [PATCH datacenter-manager 0/4] ui & ux improvements for the auto installer Shannon Sterz
2026-05-26 11:33 ` [PATCH datacenter-manager 1/4] ui: auto-installer: use empty string as default fqdn Shannon Sterz
2026-05-26 11:33 ` [PATCH datacenter-manager 2/4] ui: auto-installer: set a default template that users can adapt Shannon Sterz
2026-05-26 11:33 ` [PATCH datacenter-manager 3/4] ui: auto-instaler: auto select filter for keyboard layout and language Shannon Sterz
2026-05-26 11:33 ` [PATCH datacenter-manager 4/4] ui: auto-installer: make the fqdn field a large field Shannon Sterz
2026-05-26 12:22   ` Lukas Wagner [this message]
2026-05-26 12:29     ` Shannon Sterz
2026-05-26 12:40 ` Superseded: Re: [PATCH datacenter-manager 0/4] ui & ux improvements for the auto installer Shannon Sterz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DISLSPSWTTVH.31CXGXWG81NM2@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    --cc=s.sterz@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal