all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Shannon Sterz <s.sterz@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [PATCH datacenter-manager 1/4] ui: auto-installer: use empty string as default fqdn
Date: Tue, 26 May 2026 13:33:07 +0200	[thread overview]
Message-ID: <20260526113310.289789-2-s.sterz@proxmox.com> (raw)
In-Reply-To: <20260526113310.289789-1-s.sterz@proxmox.com>

to avoid users not setting this value themselves, as otherwise
"host.example.com" would be set as default fqdn for an answer file
config. by setting an empty string here, the placeholder is revealed
to users.

Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
 ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs b/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs
index 01e4000..6ec67d0 100644
--- a/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs
+++ b/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs
@@ -55,7 +55,7 @@ impl AddAnswerWizardProperties {
             target_filter: BTreeMap::new(),
             // global options
             country: "at".to_owned(),
-            fqdn: "host.example.com".to_owned(),
+            fqdn: String::new(),
             use_dhcp_fqdn: false,
             keyboard: answer::KeyboardLayout::default(),
             mailto: String::new(),
-- 
2.47.3





  reply	other threads:[~2026-05-26 11:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-26 11:33 [PATCH datacenter-manager 0/4] ui & ux improvements for the auto installer Shannon Sterz
2026-05-26 11:33 ` Shannon Sterz [this message]
2026-05-26 11:33 ` [PATCH datacenter-manager 2/4] ui: auto-installer: set a default template that users can adapt Shannon Sterz
2026-05-26 11:33 ` [PATCH datacenter-manager 3/4] ui: auto-instaler: auto select filter for keyboard layout and language Shannon Sterz
2026-05-26 11:33 ` [PATCH datacenter-manager 4/4] ui: auto-installer: make the fqdn field a large field Shannon Sterz
2026-05-26 12:22   ` Lukas Wagner
2026-05-26 12:29     ` Shannon Sterz
2026-05-26 12:40 ` Superseded: Re: [PATCH datacenter-manager 0/4] ui & ux improvements for the auto installer Shannon Sterz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260526113310.289789-2-s.sterz@proxmox.com \
    --to=s.sterz@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal