Re: [PATCH datacenter-manager 4/4] ui: auto-installer: make the fqdn field a large field

["Shannon Sterz" <s.sterz@proxmox.com>]

On Tue May 26, 2026 at 2:22 PM CEST, Lukas Wagner wrote:
> On Tue May 26, 2026 at 1:33 PM CEST, Shannon Sterz wrote:
>> especially with template variables the content of this field can get
>> fairly long. also moves the "FQDN from DHCP" and "Pin Network
>> Interfaces" around to match.
>>
>> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
>> ---
>>  ui/src/remotes/auto_installer/prepared_answer_form.rs | 7 +++----
>>  1 file changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/ui/src/remotes/auto_installer/prepared_answer_form.rs b/ui/src/remotes/auto_installer/prepared_answer_form.rs
>> index 28f4851..c1d2bab 100644
>> --- a/ui/src/remotes/auto_installer/prepared_answer_form.rs
>> +++ b/ui/src/remotes/auto_installer/prepared_answer_form.rs
>> @@ -323,11 +323,11 @@ pub fn render_network_options_form(
>>                  .disabled(use_dhcp_network)
>>                  .required(!use_dhcp_network),
>>          )
>> -        .with_right_field(
>> +        .with_field(
>>              tr!("FQDN from DHCP"),
>>              Checkbox::new().name("use-dhcp-fqdn").default(false),
>>          )
>> -        .with_right_field(
>> +        .with_large_field(
>>              tr!("Fully-Qualified Domain Name (FQDN)"),
>>              Field::new()
>>                  .name("fqdn")
>> @@ -346,8 +346,7 @@ pub fn render_network_options_form(
>>                  })
>>                  .required(!use_dhcp_fqdn),
>>          )
>> -        .with_right_field("", DisplayField::new().key("dummy"))
>> -        .with_right_field(
>> +        .with_field(
>>              tr!("Pin Network Interfaces"),
>>              Checkbox::new()
>>                  .name("netif-name-pinning-enabled")
>
> makes sense generally, but after this change the "Network Options" tabs
> is a bit weird to look at, since now the network configuration fields
> still span half the dialog width, without there being a second column.
>
> Maybe we should use the same proportions as on the first page of the
> wizard, so just a single column with broader labels?

we could do that yeah. my initial thought was to eventually use the
extra space for a second set of ip definitions (e.g., to provide both
ipv4 and ipv6 addresses here), but that doesn't seem to be supported in
the auto installer setup.

i'll send a v2 that adapts the layout.