From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 364941FF146 for ; Tue, 26 May 2026 14:22:59 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 54E331D1BC; Tue, 26 May 2026 14:22:58 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 26 May 2026 14:22:54 +0200 Message-Id: Subject: Re: [PATCH datacenter-manager 4/4] ui: auto-installer: make the fqdn field a large field From: "Lukas Wagner" To: "Shannon Sterz" , X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260526113310.289789-1-s.sterz@proxmox.com> <20260526113310.289789-5-s.sterz@proxmox.com> In-Reply-To: <20260526113310.289789-5-s.sterz@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779798149832 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.053 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: V5D7YRTG3MGV7NZUSL2I256D6OYNV34R X-Message-ID-Hash: V5D7YRTG3MGV7NZUSL2I256D6OYNV34R X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue May 26, 2026 at 1:33 PM CEST, Shannon Sterz wrote: > especially with template variables the content of this field can get > fairly long. also moves the "FQDN from DHCP" and "Pin Network > Interfaces" around to match. > > Signed-off-by: Shannon Sterz > --- > ui/src/remotes/auto_installer/prepared_answer_form.rs | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/ui/src/remotes/auto_installer/prepared_answer_form.rs b/ui/s= rc/remotes/auto_installer/prepared_answer_form.rs > index 28f4851..c1d2bab 100644 > --- a/ui/src/remotes/auto_installer/prepared_answer_form.rs > +++ b/ui/src/remotes/auto_installer/prepared_answer_form.rs > @@ -323,11 +323,11 @@ pub fn render_network_options_form( > .disabled(use_dhcp_network) > .required(!use_dhcp_network), > ) > - .with_right_field( > + .with_field( > tr!("FQDN from DHCP"), > Checkbox::new().name("use-dhcp-fqdn").default(false), > ) > - .with_right_field( > + .with_large_field( > tr!("Fully-Qualified Domain Name (FQDN)"), > Field::new() > .name("fqdn") > @@ -346,8 +346,7 @@ pub fn render_network_options_form( > }) > .required(!use_dhcp_fqdn), > ) > - .with_right_field("", DisplayField::new().key("dummy")) > - .with_right_field( > + .with_field( > tr!("Pin Network Interfaces"), > Checkbox::new() > .name("netif-name-pinning-enabled") makes sense generally, but after this change the "Network Options" tabs is a bit weird to look at, since now the network configuration fields still span half the dialog width, without there being a second column. Maybe we should use the same proportions as on the first page of the wizard, so just a single column with broader labels?