From: Jakob Klocker <j.klocker@proxmox.com>
To: Maximiliano Sandoval <m.sandoval@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH qemu-server v3 3/3] fix #5032: agent: sync guest time via QGA when the clock falls behind
Date: Fri, 3 Jul 2026 09:37:05 +0200 [thread overview]
Message-ID: <4bb54452-5cd0-4743-b56b-0c8242e105cc@proxmox.com> (raw)
In-Reply-To: <s8o7bnd7j7x.fsf@toolbox>
On 7/2/26 12:57 PM, Maximiliano Sandoval wrote:
> Jakob Klocker <j.klocker@proxmox.com> writes:
>
> Some comments below.
>
> One design comment: I am not sure if the functions should have an
> $override parameter, it could be argued than it is the job of the
> call-site to determine whether how to proceeded based on API+config
> parameters.
>
> disclaimer: I did not check v1 and v2's discussions.
Ignore my previous message regarding the override, I misread your
message. As discussed off-list, I will keep the $override parameter in
the `should_sync_time_on_resume` function for now, since the
responsibility of the function is to check whether
`sync-time-on-resume` should be invoked.
Thanks again for the feedback.
next prev parent reply other threads:[~2026-07-03 7:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-02 10:31 [PATCH guest-common/manager/qemu-server v3 0/3] fix #5032: add guest time sync via QGA Jakob Klocker
2026-07-02 10:31 ` [PATCH pve-guest-common v3 1/3] AbstractConfig: allow passing options to snapshot_rollback Jakob Klocker
2026-07-02 10:32 ` [PATCH pve-manager v3 2/3] fix #5032: ui: qemu agent: add sync-time-on-resume option Jakob Klocker
2026-07-02 11:00 ` Maximiliano Sandoval
2026-07-02 10:32 ` [PATCH qemu-server v3 3/3] fix #5032: agent: sync guest time via QGA when the clock falls behind Jakob Klocker
2026-07-02 10:56 ` Maximiliano Sandoval
2026-07-03 7:04 ` Jakob Klocker
2026-07-03 7:37 ` Jakob Klocker [this message]
2026-07-02 15:14 ` [PATCH guest-common/manager/qemu-server v3 0/3] fix #5032: add guest time sync via QGA Maximiliano Sandoval
2026-07-03 6:33 ` Jakob Klocker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4bb54452-5cd0-4743-b56b-0c8242e105cc@proxmox.com \
--to=j.klocker@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.