all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Jakob Klocker <j.klocker@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Jakob Klocker <j.klocker@proxmox.com>
Subject: [PATCH pve-manager v3 2/3] fix #5032: ui: qemu agent: add sync-time-on-resume option
Date: Thu,  2 Jul 2026 12:32:00 +0200	[thread overview]
Message-ID: <20260702103201.164567-3-j.klocker@proxmox.com> (raw)
In-Reply-To: <20260702103201.164567-1-j.klocker@proxmox.com>

Expose the new agent configuration option `sync-time-on-resume`
in the VM configuration GUI.

This allows enabling/disabling automatic guest clock
synchronization after clock-stalling operations.

Signed-off-by: Jakob Klocker <j.klocker@proxmox.com>
---
changes since v1:
- reword the agent option label for clarity
changes since v2:
- set default value to disabled

 www/manager6/form/AgentFeatureSelector.js | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/www/manager6/form/AgentFeatureSelector.js b/www/manager6/form/AgentFeatureSelector.js
index 3cae4194..10bb3eeb 100644
--- a/www/manager6/form/AgentFeatureSelector.js
+++ b/www/manager6/form/AgentFeatureSelector.js
@@ -45,6 +45,20 @@ Ext.define('PVE.form.AgentFeatureSelector', {
                 hidden: '{freeze_fs.checked}',
             },
         },
+        {
+            xtype: 'proxmoxcheckbox',
+            boxLabel: gettext(
+                "Synchronize guest clock with the host's after resume from saved state",
+            ),
+            name: 'sync-time-on-resume',
+            reference: 'sync_time_on_resume',
+            bind: {
+                disabled: '{!enabled.checked}',
+            },
+            disabled: true,
+            uncheckedValue: '0',
+            defaultValue: '0',
+        },
         {
             xtype: 'displayfield',
             userCls: 'pmx-hint',
@@ -74,7 +88,9 @@ Ext.define('PVE.form.AgentFeatureSelector', {
         if (PVE.Parser.parseBoolean(values['freeze-fs'])) {
             delete values['freeze-fs'];
         }
-
+        if (!PVE.Parser.parseBoolean(values['sync-time-on-resume'])) {
+            delete values['sync-time-on-resume'];
+        }
         const agentstr = PVE.Parser.printPropertyString(values, 'enabled');
         return { agent: agentstr };
     },
-- 
2.47.3




  parent reply	other threads:[~2026-07-02 10:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-02 10:31 [PATCH guest-common/manager/qemu-server v3 0/3] fix #5032: add guest time sync via QGA Jakob Klocker
2026-07-02 10:31 ` [PATCH pve-guest-common v3 1/3] AbstractConfig: allow passing options to snapshot_rollback Jakob Klocker
2026-07-02 10:32 ` Jakob Klocker [this message]
2026-07-02 11:00   ` [PATCH pve-manager v3 2/3] fix #5032: ui: qemu agent: add sync-time-on-resume option Maximiliano Sandoval
2026-07-02 10:32 ` [PATCH qemu-server v3 3/3] fix #5032: agent: sync guest time via QGA when the clock falls behind Jakob Klocker
2026-07-02 10:56   ` Maximiliano Sandoval
2026-07-03  7:04     ` Jakob Klocker
2026-07-03  7:37     ` Jakob Klocker
2026-07-02 15:14 ` [PATCH guest-common/manager/qemu-server v3 0/3] fix #5032: add guest time sync via QGA Maximiliano Sandoval
2026-07-03  6:33   ` Jakob Klocker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260702103201.164567-3-j.klocker@proxmox.com \
    --to=j.klocker@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal