From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id F37091FF135 for ; Thu, 02 Jul 2026 12:32:27 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id B3CE721448; Thu, 02 Jul 2026 12:32:21 +0200 (CEST) From: Jakob Klocker To: pve-devel@lists.proxmox.com Subject: [PATCH pve-manager v3 2/3] fix #5032: ui: qemu agent: add sync-time-on-resume option Date: Thu, 2 Jul 2026 12:32:00 +0200 Message-ID: <20260702103201.164567-3-j.klocker@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260702103201.164567-1-j.klocker@proxmox.com> References: <20260702103201.164567-1-j.klocker@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 2 DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 1.274 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: Q2H7QWW25U25HU3NOQ33TEWBFSIDFGMY X-Message-ID-Hash: Q2H7QWW25U25HU3NOQ33TEWBFSIDFGMY X-MailFrom: jklocker@dev.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Jakob Klocker X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Expose the new agent configuration option `sync-time-on-resume` in the VM configuration GUI. This allows enabling/disabling automatic guest clock synchronization after clock-stalling operations. Signed-off-by: Jakob Klocker --- changes since v1: - reword the agent option label for clarity changes since v2: - set default value to disabled www/manager6/form/AgentFeatureSelector.js | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/www/manager6/form/AgentFeatureSelector.js b/www/manager6/form/AgentFeatureSelector.js index 3cae4194..10bb3eeb 100644 --- a/www/manager6/form/AgentFeatureSelector.js +++ b/www/manager6/form/AgentFeatureSelector.js @@ -45,6 +45,20 @@ Ext.define('PVE.form.AgentFeatureSelector', { hidden: '{freeze_fs.checked}', }, }, + { + xtype: 'proxmoxcheckbox', + boxLabel: gettext( + "Synchronize guest clock with the host's after resume from saved state", + ), + name: 'sync-time-on-resume', + reference: 'sync_time_on_resume', + bind: { + disabled: '{!enabled.checked}', + }, + disabled: true, + uncheckedValue: '0', + defaultValue: '0', + }, { xtype: 'displayfield', userCls: 'pmx-hint', @@ -74,7 +88,9 @@ Ext.define('PVE.form.AgentFeatureSelector', { if (PVE.Parser.parseBoolean(values['freeze-fs'])) { delete values['freeze-fs']; } - + if (!PVE.Parser.parseBoolean(values['sync-time-on-resume'])) { + delete values['sync-time-on-resume']; + } const agentstr = PVE.Parser.printPropertyString(values, 'enabled'); return { agent: agentstr }; }, -- 2.47.3