From: Jakob Klocker <j.klocker@proxmox.com>
To: Maximiliano Sandoval <m.sandoval@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH guest-common/manager/qemu-server v3 0/3] fix #5032: add guest time sync via QGA
Date: Fri, 3 Jul 2026 08:33:11 +0200 [thread overview]
Message-ID: <b345647e-d95c-44a8-9ce6-592c5ea9ad2c@proxmox.com> (raw)
In-Reply-To: <s8oechl5sqe.fsf@toolbox>
Thanks for the feedback!
I'll adjust the error message to match`guest_fs_freeze_applicable` in
a v4.
On 7/2/26 5:14 PM, Maximiliano Sandoval wrote:
> [snip]
> @jakob: One thing that would be nice to improve is the error message
> when the guest agent is not enabled inside the guest. Perhaps it is
> possible to print a message saying that we skipped the guest-set-time
> command because the guest agent was not running, similarly to what we do
> for the guest-fsfreeze-freeze calls. However, it might be undesirable to
> add yet another guest agent call just to check if it is there though.
>
> Tested-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
>
prev parent reply other threads:[~2026-07-03 6:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-02 10:31 [PATCH guest-common/manager/qemu-server v3 0/3] fix #5032: add guest time sync via QGA Jakob Klocker
2026-07-02 10:31 ` [PATCH pve-guest-common v3 1/3] AbstractConfig: allow passing options to snapshot_rollback Jakob Klocker
2026-07-02 10:32 ` [PATCH pve-manager v3 2/3] fix #5032: ui: qemu agent: add sync-time-on-resume option Jakob Klocker
2026-07-02 11:00 ` Maximiliano Sandoval
2026-07-02 10:32 ` [PATCH qemu-server v3 3/3] fix #5032: agent: sync guest time via QGA when the clock falls behind Jakob Klocker
2026-07-02 10:56 ` Maximiliano Sandoval
2026-07-03 7:04 ` Jakob Klocker
2026-07-03 7:37 ` Jakob Klocker
2026-07-02 15:14 ` [PATCH guest-common/manager/qemu-server v3 0/3] fix #5032: add guest time sync via QGA Maximiliano Sandoval
2026-07-03 6:33 ` Jakob Klocker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b345647e-d95c-44a8-9ce6-592c5ea9ad2c@proxmox.com \
--to=j.klocker@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.