From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40])
	by lore.proxmox.com (Postfix) with ESMTPS id C91261FF142
	for <inbox@lore.proxmox.com>; Fri, 03 Jul 2026 09:37:40 +0200 (CEST)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id BBC6721387;
	Fri, 03 Jul 2026 09:37:39 +0200 (CEST)
Message-ID: <4bb54452-5cd0-4743-b56b-0c8242e105cc@proxmox.com>
Date: Fri, 3 Jul 2026 09:37:05 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird Beta
Subject: Re: [PATCH qemu-server v3 3/3] fix #5032: agent: sync guest time via
 QGA when the clock falls behind
To: Maximiliano Sandoval <m.sandoval@proxmox.com>
References: <20260702103201.164567-1-j.klocker@proxmox.com>
 <20260702103201.164567-4-j.klocker@proxmox.com> <s8o7bnd7j7x.fsf@toolbox>
Content-Language: en-US
From: Jakob Klocker <j.klocker@proxmox.com>
In-Reply-To: <s8o7bnd7j7x.fsf@toolbox>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1783064218289
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.650 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: AYQE4GU5NAS2JFVQWVXTLL7V7JYU5Q5K
X-Message-ID-Hash: AYQE4GU5NAS2JFVQWVXTLL7V7JYU5Q5K
X-MailFrom: j.klocker@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
CC: pve-devel@lists.proxmox.com
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

On 7/2/26 12:57 PM, Maximiliano Sandoval wrote:
> Jakob Klocker <j.klocker@proxmox.com> writes:
> 
> Some comments below.
> 
> One design comment: I am not sure if the functions should have an
> $override parameter, it could be argued than it is the job of the
> call-site to determine whether how to proceeded based on API+config
> parameters.
> 
> disclaimer: I did not check v1 and v2's discussions.
Ignore my previous message regarding the override, I misread your
message. As discussed off-list, I will keep the $override parameter in
the `should_sync_time_on_resume` function for now, since the
responsibility of the function is to check whether
`sync-time-on-resume` should be invoked.

Thanks again for the feedback.