[PATCH container] setup: fedora: disable static units when fixing up template

[PATCH container] setup: fedora: disable static units when fixing up template

[wukaiyang2003]

From: Kaiyang Wu <wukaiyang@loongfans.cn>

Fedora ships 'sys-mount-{config,debug}.mount' units as static units,
which would cause the units failing on startup.

Use the disable static units helper when fixing up templates to resolve
the issue, similar to how we process CentOS LXC templates.

Signed-off-by: Kaiyang Wu <wukaiyang@loongfans.cn>
---
 src/PVE/LXC/Setup/Fedora.pm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/PVE/LXC/Setup/Fedora.pm b/src/PVE/LXC/Setup/Fedora.pm
index cf383e3..91880dd 100644
--- a/src/PVE/LXC/Setup/Fedora.pm
+++ b/src/PVE/LXC/Setup/Fedora.pm
@@ -27,6 +27,8 @@ sub template_fixup {
     $self->ct_unlink('/etc/systemd/system/getty@.service');
 
     $self->remove_lxc_name_from_etc_hosts();
+
+    $self->setup_systemd_disable_static_units();
 }
 
 sub setup_init {
-- 
2.52.0

Re: [PATCH container] setup: fedora: disable static units when fixing up template

[Kaiyang Wu]

Gentle ping, can anyone please take a look?

Kaiyang

On 2026-07-08 18:10, wukaiyang2003@gmail.com wrote:
> From: Kaiyang Wu <wukaiyang@loongfans.cn>
> 
> Fedora ships 'sys-mount-{config,debug}.mount' units as static units,
> which would cause the units failing on startup.
> 
> Use the disable static units helper when fixing up templates to resolve
> the issue, similar to how we process CentOS LXC templates.
> 
> Signed-off-by: Kaiyang Wu <wukaiyang@loongfans.cn>
> ---
>   src/PVE/LXC/Setup/Fedora.pm | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/src/PVE/LXC/Setup/Fedora.pm b/src/PVE/LXC/Setup/Fedora.pm
> index cf383e3..91880dd 100644
> --- a/src/PVE/LXC/Setup/Fedora.pm
> +++ b/src/PVE/LXC/Setup/Fedora.pm
> @@ -27,6 +27,8 @@ sub template_fixup {
>       $self->ct_unlink('/etc/systemd/system/getty@.service');
>   
>       $self->remove_lxc_name_from_etc_hosts();
> +
> +    $self->setup_systemd_disable_static_units();
>   }
>   
>   sub setup_init {

Re: [PATCH container] setup: fedora: disable static units when fixing up template

[Kaiyang Wu]

Gentle ping.

Kaiyang

On 2026-07-13 11:16, Kaiyang Wu wrote:
> Gentle ping, can anyone please take a look?
> 
> Kaiyang
> 
> On 2026-07-08 18:10, wukaiyang2003@gmail.com wrote:
>> From: Kaiyang Wu <wukaiyang@loongfans.cn>
>>
>> Fedora ships 'sys-mount-{config,debug}.mount' units as static units,
>> which would cause the units failing on startup.
>>
>> Use the disable static units helper when fixing up templates to resolve
>> the issue, similar to how we process CentOS LXC templates.
>>
>> Signed-off-by: Kaiyang Wu <wukaiyang@loongfans.cn>
>> ---
>>   src/PVE/LXC/Setup/Fedora.pm | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/src/PVE/LXC/Setup/Fedora.pm b/src/PVE/LXC/Setup/Fedora.pm
>> index cf383e3..91880dd 100644
>> --- a/src/PVE/LXC/Setup/Fedora.pm
>> +++ b/src/PVE/LXC/Setup/Fedora.pm
>> @@ -27,6 +27,8 @@ sub template_fixup {
>>       $self->ct_unlink('/etc/systemd/system/getty@.service');
>>       $self->remove_lxc_name_from_etc_hosts();
>> +
>> +    $self->setup_systemd_disable_static_units();
>>   }
>>   sub setup_init {
> 

Re: [PATCH container] setup: fedora: disable static units when fixing up template

[Maximiliano Sandoval]

Kaiyang Wu <wukaiyang2003@gmail.com> writes:

> Gentle ping.
>
> Kaiyang
>
> On 2026-07-13 11:16, Kaiyang Wu wrote:

Thanks for the contribution (and ping). Could you please clarify this
point?

> Fedora ships 'sys-mount-{config,debug}.mount' units as static units,
> which would cause the units failing on startup.

1. Which Fedora version did you try?
2. How (from where) did you obtain the Fedora container template?
3. Do the units always fail after booting the container? Or is there a
   more specific setup where they do?

-- 
Maximiliano

Re: [PATCH container] setup: fedora: disable static units when fixing up template

[Kaiyang Wu]

Hi Maximiliano,

Thank you for your fast reply, here's the information:
1. Fedora 43
2. The Fedora container image is the official template shipped by PVE 
(fedora-43-default_20261115_amd64.tar.xz)
3. The units always fail after booting the container. I set the 
container up with the default options.

Best,
Kaiyang

On 2026-07-29 16:56, Maximiliano Sandoval wrote:
> Kaiyang Wu <wukaiyang2003@gmail.com> writes:
> 
>> Gentle ping.
>>
>> Kaiyang
>>
>> On 2026-07-13 11:16, Kaiyang Wu wrote:
> 
> Thanks for the contribution (and ping). Could you please clarify this
> point?
> 
>> Fedora ships 'sys-mount-{config,debug}.mount' units as static units,
>> which would cause the units failing on startup.
> 
> 1. Which Fedora version did you try?
> 2. How (from where) did you obtain the Fedora container template?
> 3. Do the units always fail after booting the container? Or is there a
>     more specific setup where they do?
> 

Re: [PATCH container] setup: fedora: disable static units when fixing up template

[Maximiliano Sandoval]

Kaiyang Wu <wukaiyang2003@gmail.com> writes:

> Hi Maximiliano,
>
> Thank you for your fast reply, here's the information:
> 1. Fedora 43
> 2. The Fedora container image is the official template shipped by PVE
> (fedora-43-default_20261115_amd64.tar.xz)
> 3. The units always fail after booting the container. I set the container up
> with the default options.
>
> Best,
> Kaiyang

Thanks for the details.

I can confirm this is reproducible with the fedora 43 and fedora 44
images on our templates.

    # systemctl --failed
      UNIT                    LOAD   ACTIVE SUB    DESCRIPTION
    ● sys-kernel-config.mount loaded failed failed Kernel Configuration File System
    ● sys-kernel-debug.mount  loaded failed failed Kernel Debug File System

In both cases with /sys/kernel/config: permission denied.

I tested that the patch fixes the issue on the fedora 43 image.

Tested-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
Reviewed-by: Maximiliano Sandoval <m.sandoval@proxmox.com>

-- 
Maximiliano