From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 699FC1FF0E5 for ; Wed, 29 Jul 2026 10:42:22 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 3CC5F213D3; Wed, 29 Jul 2026 10:42:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785314499; x=1785919299; darn=lists.proxmox.com; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=QFa23JjkIr2CW6TGQ/mgxxdJa8b0dWzIVjF3qOXb9z4=; b=LI/sp1F+Cl1pdCealx6Z2jdV9LnuDkBB6lVLt/8NuOOroKYj6Eu8lfG/zB+yz4AiuL ry3OnPZLMo88BhzZr6mkTj/gmU5VsJ1xplcbEgXuo2j2YGdJWxF8BGNRENo5HP8MVjDe SbMV5HSzhQwIvDQuYrrX01I+tL+idfJysz+rQr0vazShj9atI5GhNdlIUPpgoFVsxtxM TEn9i4KCIYW+Hq/MBIU1RV1quZRLmYusaH+lxuCO/41rcAmBH/CMgeXze14Hmoxa8Shi evbgriqGguxStDreI56b91LpzvcQFU5ew1DnYJ4ziYkCntXUnnRSp9Anr3UMTLF+3KE7 lD0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785314499; x=1785919299; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=QFa23JjkIr2CW6TGQ/mgxxdJa8b0dWzIVjF3qOXb9z4=; b=OnkvPmkZwMjSSjbijB3YAnDmt3m8ZliprVeK+nBPqoFV1NOnqzPcrhHh2oTJ8muDb5 Cfrlp4vjO3SVX5woHqdGcg9vomQAe2KT93AnqGh8sEWZGJw/Tw2Mpd8dLGPhk4omgPnS OBK0eaFWrLPAzSK4vKIGXsVfnjlarEQCzSQ9vUQXnd0rpe04GjArt4Zme4pq7pK8S7/z H2XgRFFd92HneeghuVfzLJgiE3wZjS/PF+M0k1Brjst3J6lkQfy9Q79hFeXUDlmVdjw0 OTqJA7YU8w2i2udp36FdYrz/WnfwmRTbuFh5/muFd2Prch+3N4L5jBNPTGuAZINuI+xb 4yUA== X-Gm-Message-State: AOJu0YzL3KX3YYUipIDA25+8I9+l/eIrixsfVfudGabBfQDkTn/SjF6R AbrGrYhJpaPlRaLzKD5w7t4TesDIA6G68ulCrAChlTygb52qbKbLrNbni6M+0ggP+RYUxA== X-Gm-Gg: AR+sD10uU1kT3aB+Hm8ItxWIHNNOSkWisr0I/H32EuIKEu1Vt6VO+Kqo+ax88vo5hXx vTyKeiN05CXC8JSF+xmcG7T6jGTHEbzZVLUFJdR7wbbKAZi+F0QO9/B11cAEOGngml8/OWTBccv ub13pKvsQS4VYrCmwsoMozTGqAxJy0DmloRnMT4LotoKZW4XkoDRUwZtUV0sW8ZHl1X/iJpB2Gs 6ZvSOcs9ZnDQvgQkpGwrHwLwR9MObne4JYgSDyaW5nNGSPum1ZXneytsD6jhq2Jio8LYnIidfjR 4jAjvAoyUbHC7o1WQ3PYDX/9V+JxS3J6T06+3WxhP/9N5Fmm7cbPTeyjNDm5nPvNetuXz/46Ygr lj1ZYtS9TywCpv9JBPN8Tr6tx9tnH2Im2viMvhSmOIwfXaNf1sSOvQldGC2epox7/DJuZptkT8t 22UMisE6Ax/PDRH0wBoSrq+14m/In5Mf54sp/ogff2rXprLjE9KTWwWlBIs1SbcAqRF4JtHN6IN Ft6oXI= X-Received: by 2002:a17:902:d4cc:b0:2ca:eea:eb5c with SMTP id d9443c01a7336-2d015ae2747mr57256115ad.18.1785314499171; Wed, 29 Jul 2026 01:41:39 -0700 (PDT) Message-ID: <2d147605-1557-4c18-a703-0faba3821bff@gmail.com> Date: Wed, 29 Jul 2026 16:41:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH container] setup: fedora: disable static units when fixing up template To: pve-devel@lists.proxmox.com References: <20260708101037.54778-1-wukaiyang2003@gmail.com> <5924d4fe-0b65-4525-9c76-9e1bd8c1989a@gmail.com> Content-Language: en-US From: Kaiyang Wu In-Reply-To: <5924d4fe-0b65-4525-9c76-9e1bd8c1989a@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.000 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy FREEMAIL_ENVFROM_END_DIGIT 1 Envelope-from freemail username ends in digit FREEMAIL_FROM 0.001 Sender email is commonly abused enduser mail provider KAM_SHORT 0.001 Use of a URL Shortener for very short URL RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: BXB43HC3NTYL5LGYNJJQEQHTVU725JOP X-Message-ID-Hash: BXB43HC3NTYL5LGYNJJQEQHTVU725JOP X-MailFrom: wukaiyang2003@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Kaiyang Wu X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Gentle ping. Kaiyang On 2026-07-13 11:16, Kaiyang Wu wrote: > Gentle ping, can anyone please take a look? > > Kaiyang > > On 2026-07-08 18:10, wukaiyang2003@gmail.com wrote: >> From: Kaiyang Wu >> >> Fedora ships 'sys-mount-{config,debug}.mount' units as static units, >> which would cause the units failing on startup. >> >> Use the disable static units helper when fixing up templates to resolve >> the issue, similar to how we process CentOS LXC templates. >> >> Signed-off-by: Kaiyang Wu >> --- >>   src/PVE/LXC/Setup/Fedora.pm | 2 ++ >>   1 file changed, 2 insertions(+) >> >> diff --git a/src/PVE/LXC/Setup/Fedora.pm b/src/PVE/LXC/Setup/Fedora.pm >> index cf383e3..91880dd 100644 >> --- a/src/PVE/LXC/Setup/Fedora.pm >> +++ b/src/PVE/LXC/Setup/Fedora.pm >> @@ -27,6 +27,8 @@ sub template_fixup { >>       $self->ct_unlink('/etc/systemd/system/getty@.service'); >>       $self->remove_lxc_name_from_etc_hosts(); >> + >> +    $self->setup_systemd_disable_static_units(); >>   } >>   sub setup_init { >