all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH access-control v2 0/1] tickets: sign with the hash from datacenter.cfg
@ 2026-11-13  3:06 Mark Atwood
  2026-11-13  3:06 ` [PATCH access-control v2 1/1] tickets: sign with the hash from the datacenter configuration Mark Atwood
  0 siblings, 1 reply; 3+ messages in thread
From: Mark Atwood @ 2026-11-13  3:06 UTC (permalink / raw)
  To: pve-devel

Create login, TFA, VNC and tunnel tickets with the hash that the new
'ticket-signature-hash' option of datacenter.cfg selects. Without the option
tickets are signed with SHA-1 as before.

This is the pve-access-control part of the v2 of "ticket: sign RSA tickets
with SHA-256". The pve-common part also affects Proxmox Mail Gateway, which
uses PVE::Ticket; this patch is PVE only.

Apply order across the repositories, all three are part of this series:
1. pve-common (2 patches)
2. pve-cluster (adds the datacenter.cfg option)
3. pve-access-control (reads the option and signs with it)
pve-common and pve-cluster are independent of each other. pve-access-control
needs both, but is harmless without them: it then keeps signing with SHA-1.

d/control: I did not bump the versioned dependencies, as the version numbers
depend on the release that contains the pve-common and pve-cluster changes.
They need to be bumped when applying.

Mixed clusters: nodes without pve-common 1/2 reject SHA-256 tickets, so the
option must only be set to 'sha256' once every node has that patch. The option
description says so. I did not add an automatic check against the node
versions (the new helpers in pve-cluster, 679cf2c, would allow one), as it
needs the release number that will contain 1/2. Happy to add one in
pve-manager's datacenter options update once that number is known.

Changes since v1: the pve-access-control part is new in v2. The separate CSRF
patch from v1 was applied already (07bb3b1) and is not part of this series.
Shannon asked for opt-in, so tickets are signed with the hash from the
datacenter configuration, which defaults to SHA-1. All other v1 review points
are in the pve-common cover letter.

v1: <CALkZksWBSdQa5AsvhmANGAJigcZ7FHPtgRgdu3JsRt9NX6vwSg@mail.gmail.com>
This is sent as a new thread, as is usual for a new version of a series.

Thanks to Shannon Sterz for the review of v1.

Mark Atwood (1):
  tickets: sign with the hash from the datacenter configuration

 src/PVE/AccessControl.pm               |  23 +++++-
 src/test/Makefile                      |   1 +
 src/test/ticket-signature-hash-test.pl | 100 +++++++++++++++++++++++++
 3 files changed, 122 insertions(+), 2 deletions(-)
 create mode 100644 src/test/ticket-signature-hash-test.pl


base-commit: bbc4ed63427249f98c86efd64054dabcca77bd9d



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-17 16:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-13  3:06 [PATCH access-control v2 0/1] tickets: sign with the hash from datacenter.cfg Mark Atwood
2026-11-13  3:06 ` [PATCH access-control v2 1/1] tickets: sign with the hash from the datacenter configuration Mark Atwood
2026-11-17 16:05   ` Shannon Sterz

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal