all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Mark Atwood" <mark@wolfssl.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH access-control v2 1/1] tickets: sign with the hash from the datacenter configuration
Date: Tue, 17 Nov 2026 17:05:33 +0100	[thread overview]
Message-ID: <DMXM4IWAMWIC.2PN6KWB7F5MI1@proxmox.com> (raw)
In-Reply-To: <20261113030652.3550-2-mark@wolfssl.com>

On Fri Nov 13, 2026 at 4:06 AM CET, Mark Atwood wrote:
> Read the new 'ticket-signature-hash' option of datacenter.cfg and pass
> it to PVE::Ticket::assemble_rsa_ticket() for all tickets that are
> signed here: login and TFA tickets, as well as the short-lived VNC and
> tunnel tickets. Without the option, tickets are signed with SHA-1 as
> before.
>
> This lets setups where SHA-1 signatures are not acceptable, like
> running in FIPS mode, create tickets. It depends on the option in
> pve-cluster and on the changes to PVE::Ticket in pve-common, which
> should be applied first. With older versions of those, the option is
> not set and the parameter is ignored, so tickets are still signed with
> SHA-1.

nit: typically we don't handle apply order of patches in the commit
message itself, as once it is applied is too late for that information
to be useful. rather add it in the notes section (below `---`).

also sadly this does not apply anymore.

-->8 snip 8<--




      reply	other threads:[~2026-11-17 16:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13  3:06 [PATCH access-control v2 0/1] tickets: sign with the hash from datacenter.cfg Mark Atwood
2026-11-13  3:06 ` [PATCH access-control v2 1/1] tickets: sign with the hash from the datacenter configuration Mark Atwood
2026-11-17 16:05   ` Shannon Sterz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DMXM4IWAMWIC.2PN6KWB7F5MI1@proxmox.com \
    --to=s.sterz@proxmox.com \
    --cc=mark@wolfssl.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal