From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 6C69D1FF0B7 for ; Fri, 13 Nov 2026 04:35:04 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 047CF21D72; Fri, 13 Nov 2026 04:22:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wolfssl-com.20260707.gappssmtp.com; s=20260707; t=1794539216; x=1795144016; darn=lists.proxmox.com; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=kORsHKFe8lX4ToMewi8RcIsBaLEmyoWoxP5bzZ9XzHw=; b=pkDWCt7a7Q2LLGLImQ2MraaFhFgrDVFPWKoKGKLElqK+IhmW3IDtMUWsRR3IQlW4H0 NRqAvOF/tgX7PDeh3wf1b44ubfdyJn/sDWv+hvz6cUkCq4wZC/FrVmw0BzQF07z930Z7 1rdewpaV1VHP8WPSzLS7PtyynfBM/VE5H4knfDFxt1gRDfHBStKG34gEnWzJM+3/dINv utv0OfbWuA9T930Q9zoCNAteqsOUOTOUW/lGMBwxHHNtW0KnQG+CeZ3a+ZYtqPsA/PB7 ike3j5aj21repuXRYDirKcfuDfTFM4kMqM/DeOQpFy+JFXMCDRVrDm3pJbr52jb30KY/ wRCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794539216; x=1795144016; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=kORsHKFe8lX4ToMewi8RcIsBaLEmyoWoxP5bzZ9XzHw=; b=qJK+zurUXQjRJGAOQWxvapKdyZhPjjtDIebI/Az87RG3yZd35fVpkDYz8WeJQO+xHU KHE6MoV3UfU9C/zf+HIq+RepMr4aKHGJmvpLeNijIUvx8laHOiwPHwa+D7MIMBA7vz5D QVfm4KgxLq+QsS+vDiW9px1R6IS0EUHnFhul/6DyDHhc8fVWv0nF2bAQ5dPHr4x4E4fd MJmnddB++cn6zEtlGL4UeJB2Jtm9p0PXUuCVRNHv86K5IEiTd+VJeAC3pDUgAK3LO5am MOYuwyKedd1EiGzS0pShyirM4CIikYZTg4i3BpECc06SIqKgSxn6sZjIgVOS3w+6EPP5 pLIg== X-Gm-Message-State: APuU4Z/4MOnNWoalCo7Uu7IOn/IhEwQMVOALHKgXha1wYV50o7JJczpc 4pqz9d8cmmYo1Dv2aiy+X+7PgMuAs5xV2ijVREaoD4yndlmkVyV0mE6VOLyWDQ3JuI85q9D49uG FNhp/ X-Gm-Gg: AYBFou3NhBJw8XNcF/iGUmuyyXtM/1DoOjgEmRSWnQTD6e4qEl5QNJpm5+A9VlJOOnC q+ysN8UxwP51lKYNmAq1U3GfeMVmZPdsRmbAozw/bQTVXcIFQtEdVpLy6nTw2nsieNDhITQsIAC Kz/ahcOoLulL4m2tV/op39c15R81SqHc5B/DaZlihglHtaN0uEsC+PZZ/cWSY+BcFTKcH8EuJNi eOtzvt1Hx14wCEeD5MVIxJKv5IQ8H9C2l6kQcLnuA8/G/ENXyTDp5/mjsrztE4IQ+S/DI3DIScS C0bZH2TK8P0yHJdE62YeHLyKdQ/OHukRaWTtS4/lMeH8pNICeX1naqqPnyhgyZa6/rF6z7QfsR8 TixhBvahZOGoRrantNABBZYTmJYjFO+poKF/jCLyBDjIWvEFPYXPEKY1ECdAK0DksoHGFw6gv6k oBAG/nt8NMomFELiLy3BJsZfYH+GJwBKDqyE0C7gosvyLx7j7WJ3j7VfZM0BbvD+XYyIXq+63PL m/R3VF5kxjM6ww97zUheI9ywFQ/P7wNlSEqV1pZCuUTdj0zH0QO34XEPm3lEZDzhNa4cLtBPldg +13L5D81qWc5rtQ4ROl3OCoBXiVKqZQsSn6Y2XojA3T5pVJLKXywQNiaM5XW+cbpnwOZtMaS/ym z057g3ymXf+7FZtDFUhd7rN9vif/9uFGpeoaA6IVrg4Gc0ZSvoF/y/j5efDnRbtWMsWrbI1vkzq JBONSxaWcrVM9MvsVufRsLKfHKV3NByBKDM16SgcYDchrFxoo6bm7Ef4WIKzOvdg5Q4SSjStOHx f4BKuwcyw== X-Received: by 2002:a05:6808:c3f3:b0:531:7f68:842e with SMTP id 5614622812f47-56e605b52c5mr1066208b6e.8.1794539216400; Thu, 12 Nov 2026 19:06:56 -0800 (PST) From: Mark Atwood To: pve-devel@lists.proxmox.com Subject: [PATCH access-control v2 0/1] tickets: sign with the hash from datacenter.cfg Date: Fri, 13 Nov 2026 03:06:51 +0000 Message-ID: <20261113030652.3550-1-mark@wolfssl.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DMARC_PASS -0.1 DMARC pass policy RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 6OUQRF5HMK3CVMLHH37WIMWKXAFXYGQ5 X-Message-ID-Hash: 6OUQRF5HMK3CVMLHH37WIMWKXAFXYGQ5 X-MailFrom: mark@wolfssl.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Create login, TFA, VNC and tunnel tickets with the hash that the new 'ticket-signature-hash' option of datacenter.cfg selects. Without the option tickets are signed with SHA-1 as before. This is the pve-access-control part of the v2 of "ticket: sign RSA tickets with SHA-256". The pve-common part also affects Proxmox Mail Gateway, which uses PVE::Ticket; this patch is PVE only. Apply order across the repositories, all three are part of this series: 1. pve-common (2 patches) 2. pve-cluster (adds the datacenter.cfg option) 3. pve-access-control (reads the option and signs with it) pve-common and pve-cluster are independent of each other. pve-access-control needs both, but is harmless without them: it then keeps signing with SHA-1. d/control: I did not bump the versioned dependencies, as the version numbers depend on the release that contains the pve-common and pve-cluster changes. They need to be bumped when applying. Mixed clusters: nodes without pve-common 1/2 reject SHA-256 tickets, so the option must only be set to 'sha256' once every node has that patch. The option description says so. I did not add an automatic check against the node versions (the new helpers in pve-cluster, 679cf2c, would allow one), as it needs the release number that will contain 1/2. Happy to add one in pve-manager's datacenter options update once that number is known. Changes since v1: the pve-access-control part is new in v2. The separate CSRF patch from v1 was applied already (07bb3b1) and is not part of this series. Shannon asked for opt-in, so tickets are signed with the hash from the datacenter configuration, which defaults to SHA-1. All other v1 review points are in the pve-common cover letter. v1: This is sent as a new thread, as is usual for a new version of a series. Thanks to Shannon Sterz for the review of v1. Mark Atwood (1): tickets: sign with the hash from the datacenter configuration src/PVE/AccessControl.pm | 23 +++++- src/test/Makefile | 1 + src/test/ticket-signature-hash-test.pl | 100 +++++++++++++++++++++++++ 3 files changed, 122 insertions(+), 2 deletions(-) create mode 100644 src/test/ticket-signature-hash-test.pl base-commit: bbc4ed63427249f98c86efd64054dabcca77bd9d