[PATCH manager v4 3/3] fix #4503: ui: qemu: add detect zeroes disk option

[Lukas Sichert <l.sichert@proxmox.com>]

When discard is enabled, qemu-server defaults to 'detect-zeroes=unmap'.
This can have a significant performance impact for zero writes on some
setups, while users might still want to keep guest discard/TRIM support
enabled.

Expose the option in the disk editor and default it to enabled to match
the backend behavior. Use the true-default property serialization added
previously so that disabling it explicitly writes 'detect_zeroes=0',
while enabling it omits the property.

Link: https://bugzilla.proxmox.com/show_bug.cgi?id=4503
Signed-off-by: Lukas Sichert <l.sichert@proxmox.com>
---
 www/manager6/qemu/HDEdit.js | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js
index 3ac40f42..9aae91b2 100644
--- a/www/manager6/qemu/HDEdit.js
+++ b/www/manager6/qemu/HDEdit.js
@@ -96,6 +96,7 @@ Ext.define('PVE.qemu.HDInputPanel', {
         PVE.Utils.propertyStringSet(me.drive, values.readOnly, 'ro', 'on');
         PVE.Utils.propertyStringSet(me.drive, values.cache, 'cache');
         PVE.Utils.propertyStringSet(me.drive, values.aio, 'aio');
+        PVE.Utils.propertyStringSet(me.drive, values.detect_zeroes, 'detect_zeroes', '0', true);
 
         ['mbps_rd', 'mbps_wr', 'iops_rd', 'iops_wr'].forEach((name) => {
             let burst_name = `${name}_max`;
@@ -152,6 +153,7 @@ Ext.define('PVE.qemu.HDInputPanel', {
         values.diskformat = drive.format || 'raw';
         values.cache = drive.cache || '__default__';
         values.discard = drive.discard === 'on';
+        values.detect_zeroes = PVE.Parser.parseBoolean(drive.detect_zeroes, 1);
         values.ssd = PVE.Parser.parseBoolean(drive.ssd);
         values.iothread = PVE.Parser.parseBoolean(drive.iothread);
         values.readOnly = PVE.Parser.parseBoolean(drive.ro);
@@ -317,6 +319,12 @@ Ext.define('PVE.qemu.HDInputPanel', {
                 reference: 'discard',
                 name: 'discard',
             },
+            {
+                xtype: 'proxmoxcheckbox',
+                fieldLabel: gettext('Detect zeroes'),
+                reference: 'detect_zeroes',
+                name: 'detect_zeroes',
+            },
             {
                 xtype: 'proxmoxcheckbox',
                 name: 'iothread',
-- 
2.47.3