all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Lukas Sichert <l.sichert@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Lukas Sichert <l.sichert@proxmox.com>
Subject: [PATCH manager v4 0/3] fix #4503: add configurable detect-zeroes disk option
Date: Mon, 17 Aug 2026 16:23:49 +0200	[thread overview]
Message-ID: <20260817142408.111667-1-l.sichert@proxmox.com> (raw)

When discard is enabled, qemu-server defaults to detect-zeroes=unmap,
which can negatively affect zero-write performance on some storage
setups.

This series allows users to disable zero detection while keeping guest
discard/TRIM support enabled. The first patch extends
propertyStringSet() to support properties which default to true. The
second patch converts the existing backup option to use this handling.
The final patch adds the detect-zeroes option to the disk editor.

Buglink: https://bugzilla.proxmox.com/show_bug.cgi?id=4503

changes from v3 to v4 (thanks @Fiona):
- split the change into a three-patch series
- extend propertyStringSet() to support properties
  which default to true
- use the new handling for the existing backup property
- omit detect_zeroes when enabled and only serialize detect_zeroes=0
  when explicitly disabled

changes from v2 to v3 (thanks @Fabian):
- add a comment explaining why this property is handled differently from
  the others

changes from v1 to v2:
- add the bug number to the commit header
- append the buglink to the commit body


manager:

Lukas Sichert (3):
  ui: utils: support true defaults in propertyStringSet
  ui: qemu: refactor backup property handling
  fix #4503: ui: qemu: add detect zeroes disk option

 www/manager6/Utils.js       |  4 ++--
 www/manager6/qemu/HDEdit.js | 10 +++++++++-
 2 files changed, 11 insertions(+), 3 deletions(-)


Summary over all repositories:
  2 files changed, 11 insertions(+), 3 deletions(-)

-- 
Generated by murpp 0.12.0




             reply	other threads:[~2026-08-17 14:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-17 14:23 Lukas Sichert [this message]
2026-08-17 14:23 ` [PATCH manager v4 1/3] ui: utils: support true defaults in propertyStringSet Lukas Sichert
2026-08-17 14:23 ` [PATCH manager v4 2/3] ui: qemu: refactor backup property handling Lukas Sichert
2026-08-17 14:23 ` [PATCH manager v4 3/3] fix #4503: ui: qemu: add detect zeroes disk option Lukas Sichert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260817142408.111667-1-l.sichert@proxmox.com \
    --to=l.sichert@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal