From: Lukas Sichert <l.sichert@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Lukas Sichert <l.sichert@proxmox.com>
Subject: [PATCH manager v4 1/3] ui: utils: support true defaults in propertyStringSet
Date: Mon, 17 Aug 2026 16:23:50 +0200 [thread overview]
Message-ID: <20260817142408.111667-2-l.sichert@proxmox.com> (raw)
In-Reply-To: <20260817142408.111667-1-l.sichert@proxmox.com>
Allow callers to specify that a property defaults to true. This is
useful for options where only explicitly disabling the default behavior
needs to be written to the property string.
Signed-off-by: Lukas Sichert <l.sichert@proxmox.com>
---
www/manager6/Utils.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index c86a00c5..cb70965d 100644
--- a/www/manager6/Utils.js
+++ b/www/manager6/Utils.js
@@ -1929,8 +1929,8 @@ Ext.define('PVE.Utils', {
);
},
- propertyStringSet: function (target, source, name, value) {
- if (source) {
+ propertyStringSet: function (target, source, name, value, defaultIsTrue) {
+ if (defaultIsTrue ? !source : source) {
if (value === undefined) {
target[name] = source;
} else {
--
2.47.3
next prev parent reply other threads:[~2026-08-17 14:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 14:23 [PATCH manager v4 0/3] fix #4503: add configurable detect-zeroes disk option Lukas Sichert
2026-08-17 14:23 ` Lukas Sichert [this message]
2026-08-17 14:23 ` [PATCH manager v4 2/3] ui: qemu: refactor backup property handling Lukas Sichert
2026-08-17 14:23 ` [PATCH manager v4 3/3] fix #4503: ui: qemu: add detect zeroes disk option Lukas Sichert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260817142408.111667-2-l.sichert@proxmox.com \
--to=l.sichert@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.