From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 43B401FF09B for ; Mon, 17 Aug 2026 16:24:43 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 2CEBC215A2; Mon, 17 Aug 2026 16:24:20 +0200 (CEST) From: Lukas Sichert To: pve-devel@lists.proxmox.com Subject: [PATCH manager v4 3/3] fix #4503: ui: qemu: add detect zeroes disk option Date: Mon, 17 Aug 2026 16:23:52 +0200 Message-ID: <20260817142408.111667-4-l.sichert@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260817142408.111667-1-l.sichert@proxmox.com> References: <20260817142408.111667-1-l.sichert@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1786976634042 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.710 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: J2KQQCZ2PDNZ36CSKHWHAQR6EQFP54CO X-Message-ID-Hash: J2KQQCZ2PDNZ36CSKHWHAQR6EQFP54CO X-MailFrom: l.sichert@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Lukas Sichert X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: When discard is enabled, qemu-server defaults to 'detect-zeroes=unmap'. This can have a significant performance impact for zero writes on some setups, while users might still want to keep guest discard/TRIM support enabled. Expose the option in the disk editor and default it to enabled to match the backend behavior. Use the true-default property serialization added previously so that disabling it explicitly writes 'detect_zeroes=0', while enabling it omits the property. Link: https://bugzilla.proxmox.com/show_bug.cgi?id=4503 Signed-off-by: Lukas Sichert --- www/manager6/qemu/HDEdit.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js index 3ac40f42..9aae91b2 100644 --- a/www/manager6/qemu/HDEdit.js +++ b/www/manager6/qemu/HDEdit.js @@ -96,6 +96,7 @@ Ext.define('PVE.qemu.HDInputPanel', { PVE.Utils.propertyStringSet(me.drive, values.readOnly, 'ro', 'on'); PVE.Utils.propertyStringSet(me.drive, values.cache, 'cache'); PVE.Utils.propertyStringSet(me.drive, values.aio, 'aio'); + PVE.Utils.propertyStringSet(me.drive, values.detect_zeroes, 'detect_zeroes', '0', true); ['mbps_rd', 'mbps_wr', 'iops_rd', 'iops_wr'].forEach((name) => { let burst_name = `${name}_max`; @@ -152,6 +153,7 @@ Ext.define('PVE.qemu.HDInputPanel', { values.diskformat = drive.format || 'raw'; values.cache = drive.cache || '__default__'; values.discard = drive.discard === 'on'; + values.detect_zeroes = PVE.Parser.parseBoolean(drive.detect_zeroes, 1); values.ssd = PVE.Parser.parseBoolean(drive.ssd); values.iothread = PVE.Parser.parseBoolean(drive.iothread); values.readOnly = PVE.Parser.parseBoolean(drive.ro); @@ -317,6 +319,12 @@ Ext.define('PVE.qemu.HDInputPanel', { reference: 'discard', name: 'discard', }, + { + xtype: 'proxmoxcheckbox', + fieldLabel: gettext('Detect zeroes'), + reference: 'detect_zeroes', + name: 'detect_zeroes', + }, { xtype: 'proxmoxcheckbox', name: 'iothread', -- 2.47.3