[PATCH manager 0/2] add translation notes for prefix lists and route maps

[PATCH manager 0/2] add translation notes for prefix lists and route maps

[Shannon Sterz]

adds some context for translator when it comes to translating the frr
terms "route map" and "prefix list".

Shannon Sterz (2):
  ui: add translation notes for prefix lists
  ui: add translation notes for route maps

 www/manager6/dc/Config.js                     |  6 +++++
 www/manager6/sdn/PrefixListPanel.js           | 24 ++++++++++++++++++-
 www/manager6/sdn/RouteMapPanel.js             | 12 ++++++++++
 www/manager6/sdn/controllers/BgpEdit.js       |  6 +++++
 www/manager6/sdn/controllers/EvpnEdit.js      |  6 +++++
 .../sdn/fabrics/RedistributionGrid.js         |  3 +++
 www/manager6/sdn/fabrics/bgp/FabricEdit.js    | 12 ++++++++++
 7 files changed, 68 insertions(+), 1 deletion(-)

--
2.47.3

[PATCH manager 1/2] ui: add translation notes for prefix lists

[Shannon Sterz]

Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
 www/manager6/dc/Config.js           |  3 +++
 www/manager6/sdn/PrefixListPanel.js | 24 +++++++++++++++++++++++-
 2 files changed, 26 insertions(+), 1 deletion(-)

diff --git a/www/manager6/dc/Config.js b/www/manager6/dc/Config.js
index 954e0791a..6611061d0 100644
--- a/www/manager6/dc/Config.js
+++ b/www/manager6/dc/Config.js
@@ -320,6 +320,9 @@ Ext.define('PVE.dc.Config', {
                 {
                     xtype: 'pveSDNPrefixLists',
                     groups: ['sdn'],
+                    // TRANSLATORS: Refers to an FRR prefix list, some
+                    // languages may prefer to keep "prefix list" as-is:
+                    // https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list
                     title: gettext('Prefix Lists'),
                     hidden: true,
                     iconCls: 'fa fa-list-ol',
diff --git a/www/manager6/sdn/PrefixListPanel.js b/www/manager6/sdn/PrefixListPanel.js
index 451ff9646..af40dc950 100644
--- a/www/manager6/sdn/PrefixListPanel.js
+++ b/www/manager6/sdn/PrefixListPanel.js
@@ -11,7 +11,11 @@ Ext.define('PVE.sdn.PrefixListEntry', {
 Ext.define('PVE.sdn.EditPrefixListWindow', {
     extend: 'Proxmox.window.Edit',
 
-    subject: gettext('Prefix List'),
+
+    // TRANSLATORS: Refers to an FRR prefix list, some languages may prefer to
+    // keep "prefix list" as-is:
+    // https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list subject:
+    gettext('Prefix List'),
 
     url: '/cluster/sdn/prefix-lists',
 
@@ -42,6 +46,9 @@ Ext.define('PVE.sdn.EditPrefixListEntryWindow', {
     extend: 'Proxmox.window.Edit',
     mixins: ['Proxmox.Mixin.CBind'],
 
+    // TRANSLATORS: Refers to an FRR prefix list, some languages may prefer to
+    // keep "prefix list" as-is:
+    // https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list
     subject: gettext('Prefix List Entry'),
 
     baseUrl: '/cluster/sdn/prefix-lists',
@@ -126,6 +133,9 @@ Ext.define('PVE.sdn.PrefixListView', {
     extend: 'Ext.grid.GridPanel',
     alias: ['widget.pveSDNPrefixListView'],
 
+    // TRANSLATORS: Refers to an FRR prefix list, some languages may prefer to
+    // keep "prefix list" as-is:
+    // https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list
     emptyText: gettext('No prefix list configured'),
 
     tbar: [
@@ -188,6 +198,9 @@ Ext.define('PVE.sdn.PrefixListEntriesView', {
     extend: 'Ext.grid.GridPanel',
     alias: ['widget.pveSDNPrefixListEntriesView'],
 
+    // TRANSLATORS: Refers to an FRR prefix list, some languages may prefer to
+    // keep "prefix list" as-is:
+    // https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list
     emptyText: gettext('Prefix List has no entries configured.'),
 
     config: {
@@ -279,6 +292,9 @@ Ext.define('PVE.sdn.PrefixListPanel', {
     extend: 'Ext.panel.Panel',
     alias: ['widget.pveSDNPrefixLists'],
 
+    // TRANSLATORS: Refers to an FRR prefix list, some languages may prefer to
+    // keep "prefix list" as-is:
+    // https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list
     emptyText: gettext('No prefix list configured'),
 
     viewModel: {
@@ -287,7 +303,13 @@ Ext.define('PVE.sdn.PrefixListPanel', {
                 let selection = get('prefixListGrid.selection');
 
                 return selection
+                    // TRANSLATORS: Refers to an FRR prefix list, some
+                    // languages may prefer to keep "prefix list" as-is:
+                    // https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list
                     ? gettext('Prefix List has no entries configured.')
+                    // TRANSLATORS: Refers to an FRR prefix list, some
+                    // languages may prefer to keep "prefix list" as-is:
+                    // https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list
                     : gettext('no Prefix List selected');
             },
         },
-- 
2.47.3

[PATCH manager 2/2] ui: add translation notes for route maps

[Shannon Sterz]

Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
 www/manager6/dc/Config.js                      |  3 +++
 www/manager6/sdn/RouteMapPanel.js              | 12 ++++++++++++
 www/manager6/sdn/controllers/BgpEdit.js        |  6 ++++++
 www/manager6/sdn/controllers/EvpnEdit.js       |  6 ++++++
 www/manager6/sdn/fabrics/RedistributionGrid.js |  3 +++
 www/manager6/sdn/fabrics/bgp/FabricEdit.js     | 12 ++++++++++++
 6 files changed, 42 insertions(+)

diff --git a/www/manager6/dc/Config.js b/www/manager6/dc/Config.js
index 6611061d0..d303c8c03 100644
--- a/www/manager6/dc/Config.js
+++ b/www/manager6/dc/Config.js
@@ -312,6 +312,9 @@ Ext.define('PVE.dc.Config', {
                 {
                     xtype: 'pveSDNRouteMaps',
                     groups: ['sdn'],
+                    // TRANSLATORS: "Route map" refers to an FRR route map, some
+                    // languages may prefer to keep it as-is:
+                    // https://docs.frrouting.org/en/latest/routemap.html
                     title: gettext('Route Maps'),
                     hidden: true,
                     iconCls: 'fa fa-map',
diff --git a/www/manager6/sdn/RouteMapPanel.js b/www/manager6/sdn/RouteMapPanel.js
index 71464d435..4e6081289 100644
--- a/www/manager6/sdn/RouteMapPanel.js
+++ b/www/manager6/sdn/RouteMapPanel.js
@@ -697,6 +697,9 @@ Ext.define('PVE.sdn.RouteMapExitActionField', {
 
 Ext.define('PVE.sdn.EditRouteMapEntryWindow', {
     extend: 'Proxmox.window.Edit',
+    // TRANSLATORS: "Route map" refers to an FRR route map, some languages may
+    // prefer to keep it as-is:
+    // https://docs.frrouting.org/en/latest/routemap.html
     subject: gettext('Route Map Entry'),
 
     initComponent: function () {
@@ -747,6 +750,9 @@ Ext.define('PVE.sdn.EditRouteMapEntryWindow', {
         {
             xtype: 'pveSDNRouteMapSelector',
             name: 'route-map-id',
+            // TRANSLATORS: "Route map" refers to an FRR route map, some
+            // languages may prefer to keep it as-is:
+            // https://docs.frrouting.org/en/latest/routemap.html
             fieldLabel: gettext('Route Map ID'),
             editable: true,
             notFoundIsValid: true,
@@ -811,6 +817,9 @@ Ext.define('PVE.sdn.RouteMapPanel', {
     extend: 'Ext.grid.Panel',
     alias: ['widget.pveSDNRouteMaps'],
 
+    // TRANSLATORS: "Route map" refers to an FRR route map, some languages may
+    // prefer to keep it as-is:
+    // https://docs.frrouting.org/en/latest/routemap.html
     emptyText: gettext('No route maps configured.'),
 
     store: {
@@ -878,6 +887,9 @@ Ext.define('PVE.sdn.RouteMapPanel', {
             Ext.Msg.show({
                 title: gettext('Confirm'),
                 icon: Ext.Msg.WARNING,
+                // TRANSLATORS: "Route map" refers to an FRR route map, some
+                // languages may prefer to keep it as-is:
+                // https://docs.frrouting.org/en/latest/routemap.html
                 message: gettext('Remove route map entry?'),
                 buttons: Ext.Msg.YESNO,
                 defaultFocus: 'no',
diff --git a/www/manager6/sdn/controllers/BgpEdit.js b/www/manager6/sdn/controllers/BgpEdit.js
index 8cad01ceb..f587c4039 100644
--- a/www/manager6/sdn/controllers/BgpEdit.js
+++ b/www/manager6/sdn/controllers/BgpEdit.js
@@ -76,6 +76,9 @@ Ext.define('PVE.sdn.controllers.BgpInputPanel', {
             {
                 xtype: 'pveSDNRouteMapSelector',
                 name: 'route-map-in',
+                // TRANSLATORS: "Route map" refers to an FRR route map, some
+                // languages may prefer to keep it as-is:
+                // https://docs.frrouting.org/en/latest/routemap.html
                 fieldLabel: gettext('Incoming Route Map'),
                 deleteEmpty: !me.isCreate,
                 skipEmptyText: true,
@@ -83,6 +86,9 @@ Ext.define('PVE.sdn.controllers.BgpInputPanel', {
             {
                 xtype: 'pveSDNRouteMapSelector',
                 name: 'route-map-out',
+                // TRANSLATORS: "Route map" refers to an FRR route map, some
+                // languages may prefer to keep it as-is:
+                // https://docs.frrouting.org/en/latest/routemap.html
                 fieldLabel: gettext('Outgoing Route Map'),
                 deleteEmpty: !me.isCreate,
                 skipEmptyText: true,
diff --git a/www/manager6/sdn/controllers/EvpnEdit.js b/www/manager6/sdn/controllers/EvpnEdit.js
index eb3c119ca..46e4ab735 100644
--- a/www/manager6/sdn/controllers/EvpnEdit.js
+++ b/www/manager6/sdn/controllers/EvpnEdit.js
@@ -67,6 +67,9 @@ Ext.define('PVE.sdn.controllers.EvpnInputPanel', {
             {
                 xtype: 'pveSDNRouteMapSelector',
                 name: 'route-map-in',
+                // TRANSLATORS: "Route map" refers to an FRR route map, some
+                // languages may prefer to keep it as-is:
+                // https://docs.frrouting.org/en/latest/routemap.html
                 fieldLabel: gettext('Incoming Route Map'),
                 deleteEmpty: !me.isCreate,
                 skipEmptyText: true,
@@ -74,6 +77,9 @@ Ext.define('PVE.sdn.controllers.EvpnInputPanel', {
             {
                 xtype: 'pveSDNRouteMapSelector',
                 name: 'route-map-out',
+                // TRANSLATORS: "Route map" refers to an FRR route map, some
+                // languages may prefer to keep it as-is:
+                // https://docs.frrouting.org/en/latest/routemap.html
                 fieldLabel: gettext('Outgoing Route Map'),
                 deleteEmpty: !me.isCreate,
                 skipEmptyText: true,
diff --git a/www/manager6/sdn/fabrics/RedistributionGrid.js b/www/manager6/sdn/fabrics/RedistributionGrid.js
index 846ecef0c..77dd77827 100644
--- a/www/manager6/sdn/fabrics/RedistributionGrid.js
+++ b/www/manager6/sdn/fabrics/RedistributionGrid.js
@@ -97,6 +97,9 @@ Ext.define('PVE.sdn.Fabric.RedistributionGrid', {
                 },
             },
             {
+                // TRANSLATORS: "Route map" refers to an FRR route map, some
+                // languages may prefer to keep it as-is:
+                // https://docs.frrouting.org/en/latest/routemap.html
                 text: gettext('Route Map'),
                 xtype: 'widgetcolumn',
                 dataIndex: 'route-map',
diff --git a/www/manager6/sdn/fabrics/bgp/FabricEdit.js b/www/manager6/sdn/fabrics/bgp/FabricEdit.js
index 40941b5aa..15fc52a51 100644
--- a/www/manager6/sdn/fabrics/bgp/FabricEdit.js
+++ b/www/manager6/sdn/fabrics/bgp/FabricEdit.js
@@ -32,8 +32,14 @@ Ext.define('PVE.sdn.Fabric.Bgp.Fabric.Edit', {
         {
             xtype: 'pveSDNRouteMapSelector',
             name: 'route_map_in',
+            // TRANSLATORS: "Route map" refers to an FRR route map, some
+            // languages may prefer to keep it as-is:
+            // https://docs.frrouting.org/en/latest/routemap.html
             fieldLabel: gettext('Incoming Route Map'),
             labelWidth: 120,
+            // TRANSLATORS: "Route map" refers to an FRR route map, some
+            // languages may prefer to keep it as-is:
+            // https://docs.frrouting.org/en/latest/routemap.html
             emptyText: gettext('Route Map'),
             deleteEmpty: true,
             skipEmptyText: true,
@@ -41,8 +47,14 @@ Ext.define('PVE.sdn.Fabric.Bgp.Fabric.Edit', {
         {
             xtype: 'pveSDNRouteMapSelector',
             name: 'route_map_out',
+            // TRANSLATORS: "Route map" refers to an FRR route map, some
+            // languages may prefer to keep it as-is:
+            // https://docs.frrouting.org/en/latest/routemap.html
             fieldLabel: gettext('Outgoing Route Map'),
             labelWidth: 120,
+            // TRANSLATORS: "Route map" refers to an FRR route map, some
+            // languages may prefer to keep it as-is:
+            // https://docs.frrouting.org/en/latest/routemap.html
             emptyText: gettext('Route Map'),
             deleteEmpty: true,
             skipEmptyText: true,
-- 
2.47.3

Re: [PATCH manager 0/2] add translation notes for prefix lists and route maps

[Gabriel Goller]

Teeniest tiniest nit: we should consistenly either capitalize or lowecase the
name. Either "Prefix Lists" or "prefix lists." (I am team "Prefix List".)

Otherwise:
Reviewed-by: Gabriel Goller <g.goller@proxmox.com>

Re: [PATCH manager 0/2] add translation notes for prefix lists and route maps

[Shannon Sterz]

On Mon May 18, 2026 at 2:37 PM CEST, Gabriel Goller wrote:
> Teeniest tiniest nit: we should consistenly either capitalize or lowecase the
> name. Either "Prefix Lists" or "prefix lists." (I am team "Prefix List".)

capitalizing both is not what the frr docs do [1], nor do i think that
"prefix list is a proper noun. so standard english capitalization rules
should apply -> prefix list. with "prefix" being capitalized at the
beginning of sentences and both being capitalized when using title case
[2].

since this is pre-existing and, i'd argue, unrelated, i'll send a
separate patch for this instead of a v2, if that's ok with you.

[1]: https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list
[2]: https://pve.proxmox.com/wiki/Technical_Writing_Style_Guide#Titles_and_Headlines

>
> Otherwise:
> Reviewed-by: Gabriel Goller <g.goller@proxmox.com>

thanks!

Re: [PATCH manager 0/2] add translation notes for prefix lists and route maps

[Gabriel Goller]

On 18.05.2026 14:51, Shannon Sterz wrote:
> On Mon May 18, 2026 at 2:37 PM CEST, Gabriel Goller wrote:
> > Teeniest tiniest nit: we should consistenly either capitalize or lowecase the
> > name. Either "Prefix Lists" or "prefix lists." (I am team "Prefix List".)
> 
> capitalizing both is not what the frr docs do [1], nor do i think that
> "prefix list is a proper noun. so standard english capitalization rules
> should apply -> prefix list. with "prefix" being capitalized at the
> beginning of sentences and both being capitalized when using title case
> [2].
> 
> since this is pre-existing and, i'd argue, unrelated, i'll send a
> separate patch for this instead of a v2, if that's ok with you.

sounds good!

> [1]: https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list
> [2]: https://pve.proxmox.com/wiki/Technical_Writing_Style_Guide#Titles_and_Headlines
> 
> >
> > Otherwise:
> > Reviewed-by: Gabriel Goller <g.goller@proxmox.com>
> 
> thanks!
> 

Re: [PATCH manager 1/2] ui: add translation notes for prefix lists

[Shannon Sterz]

On Mon May 18, 2026 at 2:16 PM CEST, Shannon Sterz wrote:
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
>  www/manager6/dc/Config.js           |  3 +++
>  www/manager6/sdn/PrefixListPanel.js | 24 +++++++++++++++++++++++-
>  2 files changed, 26 insertions(+), 1 deletion(-)
>
> diff --git a/www/manager6/dc/Config.js b/www/manager6/dc/Config.js
> index 954e0791a..6611061d0 100644
> --- a/www/manager6/dc/Config.js
> +++ b/www/manager6/dc/Config.js
> @@ -320,6 +320,9 @@ Ext.define('PVE.dc.Config', {
>                  {
>                      xtype: 'pveSDNPrefixLists',
>                      groups: ['sdn'],
> +                    // TRANSLATORS: Refers to an FRR prefix list, some
> +                    // languages may prefer to keep "prefix list" as-is:
> +                    // https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list
>                      title: gettext('Prefix Lists'),
>                      hidden: true,
>                      iconCls: 'fa fa-list-ol',
> diff --git a/www/manager6/sdn/PrefixListPanel.js b/www/manager6/sdn/PrefixListPanel.js
> index 451ff9646..af40dc950 100644
> --- a/www/manager6/sdn/PrefixListPanel.js
> +++ b/www/manager6/sdn/PrefixListPanel.js
> @@ -11,7 +11,11 @@ Ext.define('PVE.sdn.PrefixListEntry', {
>  Ext.define('PVE.sdn.EditPrefixListWindow', {
>      extend: 'Proxmox.window.Edit',
>
> -    subject: gettext('Prefix List'),
> +
> +    // TRANSLATORS: Refers to an FRR prefix list, some languages may prefer to
> +    // keep "prefix list" as-is:
> +    // https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list subject:
> +    gettext('Prefix List'),

just noticed the formatting got mangeled here, i'll update this in a v2
and include the capitalization alignment as an extra patch there.

>
>      url: '/cluster/sdn/prefix-lists',
>
> @@ -42,6 +46,9 @@ Ext.define('PVE.sdn.EditPrefixListEntryWindow', {
>      extend: 'Proxmox.window.Edit',
>      mixins: ['Proxmox.Mixin.CBind'],
>
> +    // TRANSLATORS: Refers to an FRR prefix list, some languages may prefer to
> +    // keep "prefix list" as-is:
> +    // https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list
>      subject: gettext('Prefix List Entry'),
>
>      baseUrl: '/cluster/sdn/prefix-lists',
> @@ -126,6 +133,9 @@ Ext.define('PVE.sdn.PrefixListView', {
>      extend: 'Ext.grid.GridPanel',
>      alias: ['widget.pveSDNPrefixListView'],
>
> +    // TRANSLATORS: Refers to an FRR prefix list, some languages may prefer to
> +    // keep "prefix list" as-is:
> +    // https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list
>      emptyText: gettext('No prefix list configured'),
>
>      tbar: [
> @@ -188,6 +198,9 @@ Ext.define('PVE.sdn.PrefixListEntriesView', {
>      extend: 'Ext.grid.GridPanel',
>      alias: ['widget.pveSDNPrefixListEntriesView'],
>
> +    // TRANSLATORS: Refers to an FRR prefix list, some languages may prefer to
> +    // keep "prefix list" as-is:
> +    // https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list
>      emptyText: gettext('Prefix List has no entries configured.'),
>
>      config: {
> @@ -279,6 +292,9 @@ Ext.define('PVE.sdn.PrefixListPanel', {
>      extend: 'Ext.panel.Panel',
>      alias: ['widget.pveSDNPrefixLists'],
>
> +    // TRANSLATORS: Refers to an FRR prefix list, some languages may prefer to
> +    // keep "prefix list" as-is:
> +    // https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list
>      emptyText: gettext('No prefix list configured'),
>
>      viewModel: {
> @@ -287,7 +303,13 @@ Ext.define('PVE.sdn.PrefixListPanel', {
>                  let selection = get('prefixListGrid.selection');
>
>                  return selection
> +                    // TRANSLATORS: Refers to an FRR prefix list, some
> +                    // languages may prefer to keep "prefix list" as-is:
> +                    // https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list
>                      ? gettext('Prefix List has no entries configured.')
> +                    // TRANSLATORS: Refers to an FRR prefix list, some
> +                    // languages may prefer to keep "prefix list" as-is:
> +                    // https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list
>                      : gettext('no Prefix List selected');
>              },
>          },

Superseded: Re: [PATCH manager 0/2] add translation notes for prefix lists and route maps

[Shannon Sterz]

Superseded-by: https://lore.proxmox.com/pve-devel/20260518132347.291801-1-s.sterz@proxmox.com/T/#t

On Mon May 18, 2026 at 2:16 PM CEST, Shannon Sterz wrote:
> adds some context for translator when it comes to translating the frr
> terms "route map" and "prefix list".
>
> Shannon Sterz (2):
>   ui: add translation notes for prefix lists
>   ui: add translation notes for route maps
>
>  www/manager6/dc/Config.js                     |  6 +++++
>  www/manager6/sdn/PrefixListPanel.js           | 24 ++++++++++++++++++-
>  www/manager6/sdn/RouteMapPanel.js             | 12 ++++++++++
>  www/manager6/sdn/controllers/BgpEdit.js       |  6 +++++
>  www/manager6/sdn/controllers/EvpnEdit.js      |  6 +++++
>  .../sdn/fabrics/RedistributionGrid.js         |  3 +++
>  www/manager6/sdn/fabrics/bgp/FabricEdit.js    | 12 ++++++++++
>  7 files changed, 68 insertions(+), 1 deletion(-)
>
> --
> 2.47.3