Re: [PATCH manager 1/2] ui: add translation notes for prefix lists

["Shannon Sterz" <s.sterz@proxmox.com>]

On Mon May 18, 2026 at 2:16 PM CEST, Shannon Sterz wrote:
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
>  www/manager6/dc/Config.js           |  3 +++
>  www/manager6/sdn/PrefixListPanel.js | 24 +++++++++++++++++++++++-
>  2 files changed, 26 insertions(+), 1 deletion(-)
>
> diff --git a/www/manager6/dc/Config.js b/www/manager6/dc/Config.js
> index 954e0791a..6611061d0 100644
> --- a/www/manager6/dc/Config.js
> +++ b/www/manager6/dc/Config.js
> @@ -320,6 +320,9 @@ Ext.define('PVE.dc.Config', {
>                  {
>                      xtype: 'pveSDNPrefixLists',
>                      groups: ['sdn'],
> +                    // TRANSLATORS: Refers to an FRR prefix list, some
> +                    // languages may prefer to keep "prefix list" as-is:
> +                    // https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list
>                      title: gettext('Prefix Lists'),
>                      hidden: true,
>                      iconCls: 'fa fa-list-ol',
> diff --git a/www/manager6/sdn/PrefixListPanel.js b/www/manager6/sdn/PrefixListPanel.js
> index 451ff9646..af40dc950 100644
> --- a/www/manager6/sdn/PrefixListPanel.js
> +++ b/www/manager6/sdn/PrefixListPanel.js
> @@ -11,7 +11,11 @@ Ext.define('PVE.sdn.PrefixListEntry', {
>  Ext.define('PVE.sdn.EditPrefixListWindow', {
>      extend: 'Proxmox.window.Edit',
>
> -    subject: gettext('Prefix List'),
> +
> +    // TRANSLATORS: Refers to an FRR prefix list, some languages may prefer to
> +    // keep "prefix list" as-is:
> +    // https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list subject:
> +    gettext('Prefix List'),

just noticed the formatting got mangeled here, i'll update this in a v2
and include the capitalization alignment as an extra patch there.

>
>      url: '/cluster/sdn/prefix-lists',
>
> @@ -42,6 +46,9 @@ Ext.define('PVE.sdn.EditPrefixListEntryWindow', {
>      extend: 'Proxmox.window.Edit',
>      mixins: ['Proxmox.Mixin.CBind'],
>
> +    // TRANSLATORS: Refers to an FRR prefix list, some languages may prefer to
> +    // keep "prefix list" as-is:
> +    // https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list
>      subject: gettext('Prefix List Entry'),
>
>      baseUrl: '/cluster/sdn/prefix-lists',
> @@ -126,6 +133,9 @@ Ext.define('PVE.sdn.PrefixListView', {
>      extend: 'Ext.grid.GridPanel',
>      alias: ['widget.pveSDNPrefixListView'],
>
> +    // TRANSLATORS: Refers to an FRR prefix list, some languages may prefer to
> +    // keep "prefix list" as-is:
> +    // https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list
>      emptyText: gettext('No prefix list configured'),
>
>      tbar: [
> @@ -188,6 +198,9 @@ Ext.define('PVE.sdn.PrefixListEntriesView', {
>      extend: 'Ext.grid.GridPanel',
>      alias: ['widget.pveSDNPrefixListEntriesView'],
>
> +    // TRANSLATORS: Refers to an FRR prefix list, some languages may prefer to
> +    // keep "prefix list" as-is:
> +    // https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list
>      emptyText: gettext('Prefix List has no entries configured.'),
>
>      config: {
> @@ -279,6 +292,9 @@ Ext.define('PVE.sdn.PrefixListPanel', {
>      extend: 'Ext.panel.Panel',
>      alias: ['widget.pveSDNPrefixLists'],
>
> +    // TRANSLATORS: Refers to an FRR prefix list, some languages may prefer to
> +    // keep "prefix list" as-is:
> +    // https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list
>      emptyText: gettext('No prefix list configured'),
>
>      viewModel: {
> @@ -287,7 +303,13 @@ Ext.define('PVE.sdn.PrefixListPanel', {
>                  let selection = get('prefixListGrid.selection');
>
>                  return selection
> +                    // TRANSLATORS: Refers to an FRR prefix list, some
> +                    // languages may prefer to keep "prefix list" as-is:
> +                    // https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list
>                      ? gettext('Prefix List has no entries configured.')
> +                    // TRANSLATORS: Refers to an FRR prefix list, some
> +                    // languages may prefer to keep "prefix list" as-is:
> +                    // https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list
>                      : gettext('no Prefix List selected');
>              },
>          },