From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 69C191FF136 for ; Mon, 18 May 2026 14:56:14 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1B06B11D78; Mon, 18 May 2026 14:56:11 +0200 (CEST) Date: Mon, 18 May 2026 14:56:06 +0200 From: Gabriel Goller To: Shannon Sterz Subject: Re: [PATCH manager 0/2] add translation notes for prefix lists and route maps Message-ID: Mail-Followup-To: Shannon Sterz , pve-devel@lists.proxmox.com References: <20260518121625.247708-1-s.sterz@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20241002-35-39f9a6 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779108953929 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.028 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: RUMTTUWLLPWXNQRQ24W7KGRBNYKJMYVZ X-Message-ID-Hash: RUMTTUWLLPWXNQRQ24W7KGRBNYKJMYVZ X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 18.05.2026 14:51, Shannon Sterz wrote: > On Mon May 18, 2026 at 2:37 PM CEST, Gabriel Goller wrote: > > Teeniest tiniest nit: we should consistenly either capitalize or lowecase the > > name. Either "Prefix Lists" or "prefix lists." (I am team "Prefix List".) > > capitalizing both is not what the frr docs do [1], nor do i think that > "prefix list is a proper noun. so standard english capitalization rules > should apply -> prefix list. with "prefix" being capitalized at the > beginning of sentences and both being capitalized when using title case > [2]. > > since this is pre-existing and, i'd argue, unrelated, i'll send a > separate patch for this instead of a v2, if that's ok with you. sounds good! > [1]: https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list > [2]: https://pve.proxmox.com/wiki/Technical_Writing_Style_Guide#Titles_and_Headlines > > > > > Otherwise: > > Reviewed-by: Gabriel Goller > > thanks! >