all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH pve-manager v3] api: sdn: fix trailing slashes in delete requests
@ 2026-04-28 12:21 David Riley
  0 siblings, 0 replies; only message in thread
From: David Riley @ 2026-04-28 12:21 UTC (permalink / raw)
  To: pve-devel; +Cc: David Riley

Fixes delete request containing double slashes (//), resulting in a
URI like `/sdn/dns//<dns>`. Although this gets normalized on the
server, a strict firewall/proxy might cause problems.

According to RFC 2396, a path may only consist of a
single slash [0].

[0] https://www.rfc-editor.org/rfc/rfc2396#section-3.3

Suggested-by: Nicolas Frey <n.frey@proxmox.com>
Signed-off-by: David Riley <d.riley@proxmox.com>
---

Notes:
    v3:
    * Fix commit message to reflect the change as "removing trailing
      slash" rather than "fixing double slash".
    * Add technical context regarding RFC 2396
    * Add Suggested-by tag for Nicolas Frey.
    
    v2:
    * Fix trailing slashes in ControllerView and IpamView to address the
      same behavior across the SDN views

 www/manager6/sdn/ControllerView.js | 2 +-
 www/manager6/sdn/DnsView.js        | 2 +-
 www/manager6/sdn/IpamView.js       | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/www/manager6/sdn/ControllerView.js b/www/manager6/sdn/ControllerView.js
index d85e85e4..cd8b4bc0 100644
--- a/www/manager6/sdn/ControllerView.js
+++ b/www/manager6/sdn/ControllerView.js
@@ -60,7 +60,7 @@ Ext.define('PVE.sdn.ControllerView', {
 
         let remove_btn = Ext.create('Proxmox.button.StdRemoveButton', {
             selModel: sm,
-            baseurl: '/cluster/sdn/controllers/',
+            baseurl: '/cluster/sdn/controllers',
             callback: () => store.load(),
         });
 
diff --git a/www/manager6/sdn/DnsView.js b/www/manager6/sdn/DnsView.js
index ba5ada5a..c5cd32bb 100644
--- a/www/manager6/sdn/DnsView.js
+++ b/www/manager6/sdn/DnsView.js
@@ -59,7 +59,7 @@ Ext.define('PVE.sdn.DnsView', {
 
         let remove_btn = Ext.create('Proxmox.button.StdRemoveButton', {
             selModel: sm,
-            baseurl: '/cluster/sdn/dns/',
+            baseurl: '/cluster/sdn/dns',
             callback: () => store.load(),
         });
 
diff --git a/www/manager6/sdn/IpamView.js b/www/manager6/sdn/IpamView.js
index ca9068cf..1764c184 100644
--- a/www/manager6/sdn/IpamView.js
+++ b/www/manager6/sdn/IpamView.js
@@ -58,7 +58,7 @@ Ext.define('PVE.sdn.IpamView', {
 
         let remove_btn = Ext.create('Proxmox.button.StdRemoveButton', {
             selModel: sm,
-            baseurl: '/cluster/sdn/ipams/',
+            baseurl: '/cluster/sdn/ipams',
             callback: () => store.load(),
         });
 
-- 
2.47.3





^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-04-28 12:22 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-28 12:21 [PATCH pve-manager v3] api: sdn: fix trailing slashes in delete requests David Riley

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal