From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id AB4941FF146 for ; Tue, 28 Apr 2026 14:22:18 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5792B116EE; Tue, 28 Apr 2026 14:22:17 +0200 (CEST) From: David Riley To: pve-devel@lists.proxmox.com Subject: [PATCH pve-manager v3] api: sdn: fix trailing slashes in delete requests Date: Tue, 28 Apr 2026 14:21:56 +0200 Message-ID: <20260428122156.82218-1-d.riley@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777378836885 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.489 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: WAWS7P7DE6QVCQ25BESALA3RS4FIVKQ5 X-Message-ID-Hash: WAWS7P7DE6QVCQ25BESALA3RS4FIVKQ5 X-MailFrom: d.riley@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Riley X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Fixes delete request containing double slashes (//), resulting in a URI like `/sdn/dns//`. Although this gets normalized on the server, a strict firewall/proxy might cause problems. According to RFC 2396, a path may only consist of a single slash [0]. [0] https://www.rfc-editor.org/rfc/rfc2396#section-3.3 Suggested-by: Nicolas Frey Signed-off-by: David Riley --- Notes: v3: * Fix commit message to reflect the change as "removing trailing slash" rather than "fixing double slash". * Add technical context regarding RFC 2396 * Add Suggested-by tag for Nicolas Frey. v2: * Fix trailing slashes in ControllerView and IpamView to address the same behavior across the SDN views www/manager6/sdn/ControllerView.js | 2 +- www/manager6/sdn/DnsView.js | 2 +- www/manager6/sdn/IpamView.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/www/manager6/sdn/ControllerView.js b/www/manager6/sdn/ControllerView.js index d85e85e4..cd8b4bc0 100644 --- a/www/manager6/sdn/ControllerView.js +++ b/www/manager6/sdn/ControllerView.js @@ -60,7 +60,7 @@ Ext.define('PVE.sdn.ControllerView', { let remove_btn = Ext.create('Proxmox.button.StdRemoveButton', { selModel: sm, - baseurl: '/cluster/sdn/controllers/', + baseurl: '/cluster/sdn/controllers', callback: () => store.load(), }); diff --git a/www/manager6/sdn/DnsView.js b/www/manager6/sdn/DnsView.js index ba5ada5a..c5cd32bb 100644 --- a/www/manager6/sdn/DnsView.js +++ b/www/manager6/sdn/DnsView.js @@ -59,7 +59,7 @@ Ext.define('PVE.sdn.DnsView', { let remove_btn = Ext.create('Proxmox.button.StdRemoveButton', { selModel: sm, - baseurl: '/cluster/sdn/dns/', + baseurl: '/cluster/sdn/dns', callback: () => store.load(), }); diff --git a/www/manager6/sdn/IpamView.js b/www/manager6/sdn/IpamView.js index ca9068cf..1764c184 100644 --- a/www/manager6/sdn/IpamView.js +++ b/www/manager6/sdn/IpamView.js @@ -58,7 +58,7 @@ Ext.define('PVE.sdn.IpamView', { let remove_btn = Ext.create('Proxmox.button.StdRemoveButton', { selModel: sm, - baseurl: '/cluster/sdn/ipams/', + baseurl: '/cluster/sdn/ipams', callback: () => store.load(), }); -- 2.47.3