all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Daniel Kral <d.kral@proxmox.com>
Subject: applied: [PATCH-SERIES ha-manager v4 00/17] some sid parsing and LRM speedup improvements
Date: Wed, 18 Nov 2026 21:39:23 +0100	[thread overview]
Message-ID: <179503426431.3079592.6627466755220214141.b4-ty@b4> (raw)
In-Reply-To: <20261118144502.231134-1-d.kral@proxmox.com>

On Wed, 18 Nov 2026 15:44:45 +0100, Daniel Kral wrote:
> Changes since v3:
> - rebase on master
> - drop R-b and T-b from @Michael from patch #8 (now also includes the
>   new parse_sid() uses Fiona's JSON migrate schema introduced)
> 
> Changes since v2 (thanks a lot @Michael!):
> - add R-b and T-b from @Michael to patches except #2 and #9
> - drop s/$name/$vmid/ from PVE::HA::LRM and PVE::HA::Resources in #2
> - new patch #9: use an eval around the maintenance work branch, similar
>   to what is catched in the active work branch
> 
> [...]

Applied, with some follow-ups, thanks!

As Michael noted, after the rebase onto the migration options the
migrate endpoint still used $type in its handler, so
PVE::API2::HA::Resources did not compile from patch 3 on, and its
resolve_type hook still called parse_sid(), so bare VMIDs failed there.
I fixed both in place, reworded some commit messages and the new
property comments in the LRM, and added a simulator test for the
maintenance case that patch 9 fixes.

On top of that, parse_vmid_or_sid() now only returns the SID. Its return
list was shaped differently from the one of parse_sid(), which made it
easy to mix the two up at a call site.

One thing that might be worth a follow-up: the state-change part of the
maintenance branch in work() still calls run_workers(), and with it
get_max_workers() and read_service_config(), outside of an eval. If the
pmxcfs is unavailable after all HA resources moved away, the LRM still
dies there; test-cfs-unavailable3 without its node affinity rule shows
this.

[01/17] resources: remove commented ipaddr resource type
        commit: e4159708ff132d71c49e34059d41f5e2d32d3738
[02/17] tree-wide: use the term vmid instead of name when referring to VMs/CTs
        commit: 5fb08630395355c6a7aa5d3e6ed654f98e580622
[03/17] tree-wide: remove unused return values at parse_sid callsites
        commit: b1c335b9a4f5cb661ad34015f45317e6e0c316cc
[04/17] config: make update_single_resource_config_inplace only allow sids
        commit: c2959fa19e7043eda9bed37ecd578bb90a0a9411
[05/17] config: make parse_sid always return an array
        commit: 4ce627dee96991900c7107c0eb12de23c31d0165
[06/17] config: use early returns in parse_sid
        commit: 3c64baef6f6d51ff947c70bf261d65f0879484ef
[07/17] config: introduce separate parse_vmid_or_sid helper subroutine
        commit: 40624bdc89874af9bc569a1f47712bf898563bdc
[08/17] config: drop the unchanged sid from parse_sid's return values
        commit: 14e44918a34ab9a22da62706f55558711e2657d1
[09/17] lrm: catch and report dies while the LRM is in maintenance state
        commit: 5e93b76ede98aad80a287f28fb527594dc5e7893
[10/17] lrm: rename update_lrm_status to flush_lrm_status
        commit: a6d61ee525c81958bbfe45536db3e893431fda3e
[11/17] lrm: rename update_service_status to update_lrm_status
        commit: 4577bb5fb49cde4b8256bb6e42c75dd04ed27a40
[12/17] lrm: document and initialize LRM instance properties
        commit: 21f077f44232532dff3462697be0c3a252a0782b
[13/17] lrm: read the manager status once per work iteration
        commit: 1a438fc5bc3e96b4a573bb4a784ff9fdba7958cc
[14/17] lrm: read service config once per work iteration
        commit: 7ea7e8a6094626060a923dfd8b6148a3ff9a3994
[15/17] lrm: compute valid service uids hash set once per work iteration
        commit: 3098c15ec2175e8c6aa0f92ebf93586920183468
[16/17] lrm: resource_command_finished: avoid writing stale LRM results
        commit: 27bfdcda26ca0dac12e2e836734fb67611998a58
[17/17] lrm: prune stale LRM results once per work iteration
        commit: d9f3113cd65ad03d0677962698925eadc429c7a9

Follow-ups:
      test: add test for LRM maintenance mode with unavailable pmxcfs
        commit: f0696977cf0b269d83cee2a366ba071f1e9f56cf
      config: make parse_vmid_or_sid only return the SID
        commit: 85c4b74d68d1824b6f3371fac20169c855b9bbcf




      parent reply	other threads:[~2026-11-18 20:40 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 14:44 [PATCH-SERIES ha-manager v4 00/17] some sid parsing and LRM speedup improvements Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 01/17] resources: remove commented ipaddr resource type Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 02/17] tree-wide: use the term vmid instead of name when referring to VMs/CTs Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 03/17] tree-wide: remove unused return values at parse_sid callsites Daniel Kral
2026-11-18 15:20   ` Michael Köppl
2026-11-18 14:44 ` [PATCH ha-manager v4 04/17] config: make update_single_resource_config_inplace only allow sids Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 05/17] make parse_sid always return an array Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 06/17] config: use early returns in parse_sid Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 07/17] config: introduce separate parse_vmid_or_sid helper subroutine Daniel Kral
2026-11-18 16:02   ` Michael Köppl
2026-11-18 14:44 ` [PATCH ha-manager v4 08/17] drop the unmodified sid return array entry value from parse_sid Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 09/17] lrm: catch and report dies while the LRM is in maintenance state Daniel Kral
2026-11-18 16:12   ` Michael Köppl
2026-11-18 14:44 ` [PATCH ha-manager v4 10/17] lrm: rename update_lrm_status to flush_lrm_status Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 11/17] lrm: rename update_service_status to update_lrm_status Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 12/17] lrm: document and initialize LRM instance properties Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 13/17] lrm: update the service status once per work iteration Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 14/17] lrm: read service config " Daniel Kral
2026-11-18 14:45 ` [PATCH ha-manager v4 15/17] lrm: compute valid service uids hash set " Daniel Kral
2026-11-18 14:45 ` [PATCH ha-manager v4 16/17] lrm: resource_command_finished: avoid writing stale LRM results Daniel Kral
2026-11-18 14:45 ` [PATCH ha-manager v4 17/17] lrm: prune stale LRM results once per work iteration Daniel Kral
2026-11-18 20:39 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179503426431.3079592.6627466755220214141.b4-ty@b4 \
    --to=t.lamprecht@proxmox.com \
    --cc=d.kral@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal