From: "Michael Köppl" <m.koeppl@proxmox.com>
To: "Daniel Kral" <d.kral@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH ha-manager v4 07/17] config: introduce separate parse_vmid_or_sid helper subroutine
Date: Wed, 18 Nov 2026 17:02:54 +0100 [thread overview]
Message-ID: <DMYGP1DOQLNM.398JVPTG0HMKJ@proxmox.com> (raw)
In-Reply-To: <20261118144502.231134-8-d.kral@proxmox.com>
On Wed Nov 18, 2026 at 3:44 PM CET, Daniel Kral wrote:
[snip]
> @@ -361,7 +362,7 @@ __PACKAGE__->register_method({
> code => sub {
> my ($param) = @_;
>
> - my ($sid) = PVE::HA::Config::parse_sid(extract_param($param, 'sid'));
> + my ($sid) = PVE::HA::Config::parse_vmid_or_sid(extract_param($param, 'sid'));
> my $purge = extract_param($param, 'purge') // 1;
>
> if (!PVE::HA::Config::service_is_configured($sid)) {
> @@ -461,7 +462,7 @@ __PACKAGE__->register_method({
>
> my $result = {};
>
> - my ($sid) = PVE::HA::Config::parse_sid(extract_param($param, 'sid'));
> + my ($sid) = PVE::HA::Config::parse_vmid_or_sid(extract_param($param, 'sid'));
After the rebase, the `resolve_type` hook of this endpoint still calls
`parse_sid()`. With this patch applied, this results in `ha-manager
migrate 100 pve2-cluster` failing with "unable to parse service id
'100'", while passing `--resource-type vm` works.
> my $req_node = extract_param($param, 'node');
> my $resource_type = extract_param($param, 'resource-type');
> if ($resource_type ne $type) {
> @@ -585,7 +586,7 @@ __PACKAGE__->register_method({
>
> my $result = {};
>
> - my ($sid) = PVE::HA::Config::parse_sid(extract_param($param, 'sid'));
> + my ($sid) = PVE::HA::Config::parse_vmid_or_sid(extract_param($param, 'sid'));
> my $req_node = extract_param($param, 'node');
>
> PVE::HA::Config::service_is_ha_managed($sid);
> diff --git a/src/PVE/CLI/ha_manager.pm b/src/PVE/CLI/ha_manager.pm
[snip]
next prev parent reply other threads:[~2026-11-18 16:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 14:44 [PATCH-SERIES ha-manager v4 00/17] some sid parsing and LRM speedup improvements Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 01/17] resources: remove commented ipaddr resource type Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 02/17] tree-wide: use the term vmid instead of name when referring to VMs/CTs Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 03/17] tree-wide: remove unused return values at parse_sid callsites Daniel Kral
2026-11-18 15:20 ` Michael Köppl
2026-11-18 14:44 ` [PATCH ha-manager v4 04/17] config: make update_single_resource_config_inplace only allow sids Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 05/17] make parse_sid always return an array Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 06/17] config: use early returns in parse_sid Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 07/17] config: introduce separate parse_vmid_or_sid helper subroutine Daniel Kral
2026-11-18 16:02 ` Michael Köppl [this message]
2026-11-18 14:44 ` [PATCH ha-manager v4 08/17] drop the unmodified sid return array entry value from parse_sid Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 09/17] lrm: catch and report dies while the LRM is in maintenance state Daniel Kral
2026-11-18 16:12 ` Michael Köppl
2026-11-18 14:44 ` [PATCH ha-manager v4 10/17] lrm: rename update_lrm_status to flush_lrm_status Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 11/17] lrm: rename update_service_status to update_lrm_status Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 12/17] lrm: document and initialize LRM instance properties Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 13/17] lrm: update the service status once per work iteration Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 14/17] lrm: read service config " Daniel Kral
2026-11-18 14:45 ` [PATCH ha-manager v4 15/17] lrm: compute valid service uids hash set " Daniel Kral
2026-11-18 14:45 ` [PATCH ha-manager v4 16/17] lrm: resource_command_finished: avoid writing stale LRM results Daniel Kral
2026-11-18 14:45 ` [PATCH ha-manager v4 17/17] lrm: prune stale LRM results once per work iteration Daniel Kral
2026-11-18 20:39 ` applied: [PATCH-SERIES ha-manager v4 00/17] some sid parsing and LRM speedup improvements Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMYGP1DOQLNM.398JVPTG0HMKJ@proxmox.com \
--to=m.koeppl@proxmox.com \
--cc=d.kral@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.