From: Daniel Kral <d.kral@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH ha-manager v4 17/17] lrm: prune stale LRM results once per work iteration
Date: Wed, 18 Nov 2026 15:45:02 +0100 [thread overview]
Message-ID: <20261118144502.231134-18-d.kral@proxmox.com> (raw)
In-Reply-To: <20261118144502.231134-1-d.kral@proxmox.com>
resource_command_finished() writes only LRM results to $self->{results},
whose HA resource command uid is still active in the current LRM round,
i.e., are in $self->{service_status_uids}.
Therefore, the only other reason for stale LRM results in
$self->{results} is because updates to $self->{service_status} and
therefore $self->{service_status_uids} made these become stale.
As both $self->{service_status} and $self->{service_status_uids} are
only updated in update_lrm_status(), pruning these stale LRM results is
only necessary whenever these change.
This makes the LRM results exposed in the lrm_status file be pruned more
often, which only happened before when the LRM was restarted or
resource_command_finished() was called.
A test startup of 768 HA resources on a single node at the same time
showed a ~21.8x speedup for resource_command_finished().
+---------------------------+---------------+--------------+
| Subroutine | Before Change | After Change |
+---------------------------+---------------+--------------+
| check_active_workers | 4.09ms | 998µs |
| resource_command_finished | 1.09ms | 50µs |
+---------------------------+---------------+--------------+
The profiling was done on a physical host with Devel::NYTProf 6.14 [0].
[0] https://metacpan.org/pod/Devel::NYTProf
Signed-off-by: Daniel Kral <d.kral@proxmox.com>
Reviewed-by: Michael Köppl <m.koeppl@proxmox.com>
Tested-by: Michael Köppl <m.koeppl@proxmox.com>
---
src/PVE/HA/LRM.pm | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/src/PVE/HA/LRM.pm b/src/PVE/HA/LRM.pm
index 3afac344..5962ad34 100644
--- a/src/PVE/HA/LRM.pm
+++ b/src/PVE/HA/LRM.pm
@@ -240,6 +240,11 @@ sub update_lrm_status {
$self->{service_status_uids}->{$uid} = 1;
}
+ # prune results which became stale since the last update
+ for my $uid (keys $self->{results}->%*) {
+ delete $self->{results}->{$uid} if !$self->{service_status_uids}->{$uid};
+ }
+
my $nodename = $haenv->nodename();
$self->{node_status} = $ms->{node_status}->{$nodename} || 'unknown';
@@ -920,13 +925,6 @@ sub resource_command_finished {
state => $w->{state},
exit_code => $exit_code,
};
-
- my $results = {};
- foreach my $id (keys %{ $self->{results} }) {
- next if !$self->{service_status_uids}->{$id};
- $results->{$id} = $self->{results}->{$id};
- }
- $self->{results} = $results;
}
# processes the exit code from a finished resource agent, so that the CRM knows
--
2.47.3
next prev parent reply other threads:[~2026-11-18 14:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 14:44 [PATCH-SERIES ha-manager v4 00/17] some sid parsing and LRM speedup improvements Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 01/17] resources: remove commented ipaddr resource type Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 02/17] tree-wide: use the term vmid instead of name when referring to VMs/CTs Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 03/17] tree-wide: remove unused return values at parse_sid callsites Daniel Kral
2026-11-18 15:20 ` Michael Köppl
2026-11-18 14:44 ` [PATCH ha-manager v4 04/17] config: make update_single_resource_config_inplace only allow sids Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 05/17] make parse_sid always return an array Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 06/17] config: use early returns in parse_sid Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 07/17] config: introduce separate parse_vmid_or_sid helper subroutine Daniel Kral
2026-11-18 16:02 ` Michael Köppl
2026-11-18 14:44 ` [PATCH ha-manager v4 08/17] drop the unmodified sid return array entry value from parse_sid Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 09/17] lrm: catch and report dies while the LRM is in maintenance state Daniel Kral
2026-11-18 16:12 ` Michael Köppl
2026-11-18 14:44 ` [PATCH ha-manager v4 10/17] lrm: rename update_lrm_status to flush_lrm_status Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 11/17] lrm: rename update_service_status to update_lrm_status Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 12/17] lrm: document and initialize LRM instance properties Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 13/17] lrm: update the service status once per work iteration Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 14/17] lrm: read service config " Daniel Kral
2026-11-18 14:45 ` [PATCH ha-manager v4 15/17] lrm: compute valid service uids hash set " Daniel Kral
2026-11-18 14:45 ` [PATCH ha-manager v4 16/17] lrm: resource_command_finished: avoid writing stale LRM results Daniel Kral
2026-11-18 14:45 ` Daniel Kral [this message]
2026-11-18 20:39 ` applied: [PATCH-SERIES ha-manager v4 00/17] some sid parsing and LRM speedup improvements Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118144502.231134-18-d.kral@proxmox.com \
--to=d.kral@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.