From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 1C0B91FF0E3 for ; Wed, 18 Nov 2026 21:40:09 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 8A46921771; Wed, 18 Nov 2026 21:40:07 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Daniel Kral Subject: applied: [PATCH-SERIES ha-manager v4 00/17] some sid parsing and LRM speedup improvements Date: Wed, 18 Nov 2026 21:39:23 +0100 Message-ID: <179503426431.3079592.6627466755220214141.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261118144502.231134-1-d.kral@proxmox.com> References: <20261118144502.231134-1-d.kral@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795034404541 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.038 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) KAM_LOTSOFHASH 0.25 Emails with lots of hash-like gibberish RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: X62FDYVWXCQ3GGKPQ5AC43FUENDDUICU X-Message-ID-Hash: X62FDYVWXCQ3GGKPQ5AC43FUENDDUICU X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 18 Nov 2026 15:44:45 +0100, Daniel Kral wrote: > Changes since v3: > - rebase on master > - drop R-b and T-b from @Michael from patch #8 (now also includes the > new parse_sid() uses Fiona's JSON migrate schema introduced) > > Changes since v2 (thanks a lot @Michael!): > - add R-b and T-b from @Michael to patches except #2 and #9 > - drop s/$name/$vmid/ from PVE::HA::LRM and PVE::HA::Resources in #2 > - new patch #9: use an eval around the maintenance work branch, similar > to what is catched in the active work branch > > [...] Applied, with some follow-ups, thanks! As Michael noted, after the rebase onto the migration options the migrate endpoint still used $type in its handler, so PVE::API2::HA::Resources did not compile from patch 3 on, and its resolve_type hook still called parse_sid(), so bare VMIDs failed there. I fixed both in place, reworded some commit messages and the new property comments in the LRM, and added a simulator test for the maintenance case that patch 9 fixes. On top of that, parse_vmid_or_sid() now only returns the SID. Its return list was shaped differently from the one of parse_sid(), which made it easy to mix the two up at a call site. One thing that might be worth a follow-up: the state-change part of the maintenance branch in work() still calls run_workers(), and with it get_max_workers() and read_service_config(), outside of an eval. If the pmxcfs is unavailable after all HA resources moved away, the LRM still dies there; test-cfs-unavailable3 without its node affinity rule shows this. [01/17] resources: remove commented ipaddr resource type commit: e4159708ff132d71c49e34059d41f5e2d32d3738 [02/17] tree-wide: use the term vmid instead of name when referring to VMs/CTs commit: 5fb08630395355c6a7aa5d3e6ed654f98e580622 [03/17] tree-wide: remove unused return values at parse_sid callsites commit: b1c335b9a4f5cb661ad34015f45317e6e0c316cc [04/17] config: make update_single_resource_config_inplace only allow sids commit: c2959fa19e7043eda9bed37ecd578bb90a0a9411 [05/17] config: make parse_sid always return an array commit: 4ce627dee96991900c7107c0eb12de23c31d0165 [06/17] config: use early returns in parse_sid commit: 3c64baef6f6d51ff947c70bf261d65f0879484ef [07/17] config: introduce separate parse_vmid_or_sid helper subroutine commit: 40624bdc89874af9bc569a1f47712bf898563bdc [08/17] config: drop the unchanged sid from parse_sid's return values commit: 14e44918a34ab9a22da62706f55558711e2657d1 [09/17] lrm: catch and report dies while the LRM is in maintenance state commit: 5e93b76ede98aad80a287f28fb527594dc5e7893 [10/17] lrm: rename update_lrm_status to flush_lrm_status commit: a6d61ee525c81958bbfe45536db3e893431fda3e [11/17] lrm: rename update_service_status to update_lrm_status commit: 4577bb5fb49cde4b8256bb6e42c75dd04ed27a40 [12/17] lrm: document and initialize LRM instance properties commit: 21f077f44232532dff3462697be0c3a252a0782b [13/17] lrm: read the manager status once per work iteration commit: 1a438fc5bc3e96b4a573bb4a784ff9fdba7958cc [14/17] lrm: read service config once per work iteration commit: 7ea7e8a6094626060a923dfd8b6148a3ff9a3994 [15/17] lrm: compute valid service uids hash set once per work iteration commit: 3098c15ec2175e8c6aa0f92ebf93586920183468 [16/17] lrm: resource_command_finished: avoid writing stale LRM results commit: 27bfdcda26ca0dac12e2e836734fb67611998a58 [17/17] lrm: prune stale LRM results once per work iteration commit: d9f3113cd65ad03d0677962698925eadc429c7a9 Follow-ups: test: add test for LRM maintenance mode with unavailable pmxcfs commit: f0696977cf0b269d83cee2a366ba071f1e9f56cf config: make parse_vmid_or_sid only return the SID commit: 85c4b74d68d1824b6f3371fac20169c855b9bbcf