[PATCH manager v2] ui: ceph: pool: set target ratio to 0 when the value is not set

[PATCH manager v2] ui: ceph: pool: set target ratio to 0 when the value is not set

[Maximiliano Sandoval]

Leaving the field empty in the web UI results in the parameter being dropped
before the API call and the value remaining unchanged on the pool.

We address this by passing down target_size_ratio=0 to the API if the value is
not explicitly set, this results in the key being unset on the pool.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---

Notes:
    One can get the target_size_ratio using
    
        $ ceph osd pool get <POOL_NAME> target_size_ratio
    
    after setting the value to 0 through the API or Web UI (explicitly as 0, or
    leaving the field as empty) it should output
    
        Error ENOENT: option 'target_size_ratio' is not set on pool '<POOL_NAME>'
    
    Note that:
    - This is handled automatically for the target_size property.
    - The same fix does not work for the Min. # of PGs field
    
    Differences from v1:
     - Rebased on top of master
     - Reworded commit message

 www/manager6/ceph/Pool.js | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/www/manager6/ceph/Pool.js b/www/manager6/ceph/Pool.js
index 80d57f113..a64230fbc 100644
--- a/www/manager6/ceph/Pool.js
+++ b/www/manager6/ceph/Pool.js
@@ -234,7 +234,11 @@ Ext.define('PVE.CephPoolInputPanel', {
     onGetValues: function (values) {
         Object.keys(values || {}).forEach(function (name) {
             if (values[name] === '') {
-                delete values[name];
+                if (name === 'target_size_ratio') {
+                    values[name] = 0;
+                } else {
+                    delete values[name];
+                }
             }
         });
 
-- 
2.47.3

applied: [PATCH manager v2] ui: ceph: pool: set target ratio to 0 when the value is not set

[Fiona Ebner]

On Wed, 29 Jul 2026 12:26:25 +0200, Maximiliano Sandoval wrote:
> Leaving the field empty in the web UI results in the parameter being dropped
> before the API call and the value remaining unchanged on the pool.
> 
> We address this by passing down target_size_ratio=0 to the API if the value is
> not explicitly set, this results in the key being unset on the pool.
> 
> 
> [...]

Applied, thanks!

[1/1] ui: ceph: pool: set target ratio to 0 when the value is not set
      commit: b0e5da32437ef28c1f08a89be83addf6e0382855