From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 9A7CE1FF0E5 for ; Wed, 29 Jul 2026 12:26:57 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 566E92133E; Wed, 29 Jul 2026 12:26:57 +0200 (CEST) From: Maximiliano Sandoval To: pve-devel@lists.proxmox.com Subject: [PATCH manager v2] ui: ceph: pool: set target ratio to 0 when the value is not set Date: Wed, 29 Jul 2026 12:26:25 +0200 Message-ID: <20260729102628.276253-1-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1785320749711 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.220 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: N7SIIHJ2VU7CNVSPD53UCPIITSEZVZPI X-Message-ID-Hash: N7SIIHJ2VU7CNVSPD53UCPIITSEZVZPI X-MailFrom: m.sandoval@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Leaving the field empty in the web UI results in the parameter being dropped before the API call and the value remaining unchanged on the pool. We address this by passing down target_size_ratio=0 to the API if the value is not explicitly set, this results in the key being unset on the pool. Signed-off-by: Maximiliano Sandoval --- Notes: One can get the target_size_ratio using $ ceph osd pool get target_size_ratio after setting the value to 0 through the API or Web UI (explicitly as 0, or leaving the field as empty) it should output Error ENOENT: option 'target_size_ratio' is not set on pool '' Note that: - This is handled automatically for the target_size property. - The same fix does not work for the Min. # of PGs field Differences from v1: - Rebased on top of master - Reworded commit message www/manager6/ceph/Pool.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/www/manager6/ceph/Pool.js b/www/manager6/ceph/Pool.js index 80d57f113..a64230fbc 100644 --- a/www/manager6/ceph/Pool.js +++ b/www/manager6/ceph/Pool.js @@ -234,7 +234,11 @@ Ext.define('PVE.CephPoolInputPanel', { onGetValues: function (values) { Object.keys(values || {}).forEach(function (name) { if (values[name] === '') { - delete values[name]; + if (name === 'target_size_ratio') { + values[name] = 0; + } else { + delete values[name]; + } } }); -- 2.47.3