[PATCH datacenter-manager] ui: auto-installer: use empty string as default fqdn

[PATCH datacenter-manager] ui: auto-installer: use empty string as default fqdn

[Shannon Sterz]

to avoid users not setting this value themselves, as otherwise
"host.example.com" would be set as default fqdn for an answer file
config.

Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
 ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs b/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs
index f1b443e..64d746f 100644
--- a/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs
+++ b/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs
@@ -55,7 +55,7 @@ impl AddAnswerWizardProperties {
             target_filter: BTreeMap::new(),
             // global options
             country: "at".to_owned(),
-            fqdn: "host.example.com".to_owned(),
+            fqdn: String::new(),
             use_dhcp_fqdn: false,
             keyboard: answer::KeyboardLayout::default(),
             mailto: String::new(),
-- 
2.47.3

Re: [PATCH datacenter-manager] ui: auto-installer: use empty string as default fqdn

[Fabian Grünbichler]

On May 22, 2026 4:46 pm, Shannon Sterz wrote:
> to avoid users not setting this value themselves, as otherwise
> "host.example.com" would be set as default fqdn for an answer file
> config.
> 
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
>  ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs b/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs
> index f1b443e..64d746f 100644
> --- a/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs
> +++ b/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs
> @@ -55,7 +55,7 @@ impl AddAnswerWizardProperties {
>              target_filter: BTreeMap::new(),
>              // global options
>              country: "at".to_owned(),
> -            fqdn: "host.example.com".to_owned(),
> +            fqdn: String::new(),

this looks okay to me, though I wonder whether it wouldn't be better to
either default to

>              use_dhcp_fqdn: false,

this, or use the placeholder with the template vars as default value but
do not accept it as valid?

>              keyboard: answer::KeyboardLayout::default(),
>              mailto: String::new(),
> -- 
> 2.47.3
> 
> 
> 
> 
> 
> 

Re: [PATCH datacenter-manager] ui: auto-installer: use empty string as default fqdn

[Shannon Sterz]

On Tue May 26, 2026 at 11:08 AM CEST, Fabian Grünbichler wrote:
> On May 22, 2026 4:46 pm, Shannon Sterz wrote:
>> to avoid users not setting this value themselves, as otherwise
>> "host.example.com" would be set as default fqdn for an answer file
>> config.
>>
>> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
>> ---
>>  ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs b/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs
>> index f1b443e..64d746f 100644
>> --- a/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs
>> +++ b/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs
>> @@ -55,7 +55,7 @@ impl AddAnswerWizardProperties {
>>              target_filter: BTreeMap::new(),
>>              // global options
>>              country: "at".to_owned(),
>> -            fqdn: "host.example.com".to_owned(),
>> +            fqdn: String::new(),
>
> this looks okay to me, though I wonder whether it wouldn't be better to
> either default to
>
>>              use_dhcp_fqdn: false,
>
> this, or use the placeholder with the template vars as default value but
> do not accept it as valid?

the placeholder with a template vars is already set in the ui here [1]
as a proper placeholder (e.g. greyed-out; only shown when the field is
empty). so setting an empty value here exposes this placeholder to the
user and also mark the corresponding field as empty -> users get a
validation error if they try to proceed without changing it.

this approach also has the advantage of not special casing a specific
value.

sorry this could have been clearer in my commit message above.

[1]: https://git.proxmox.com/?p=proxmox-datacenter-manager.git;a=blob;f=ui/src/remotes/auto_installer/prepared_answer_form.rs;h=72d2856e33ac2759168cf0a4a56a7acd403f41d3;hb=HEAD#l328

>>              keyboard: answer::KeyboardLayout::default(),
>>              mailto: String::new(),
>> --
>> 2.47.3
>>
>>
>>
>>
>>
>>

Re: [PATCH datacenter-manager] ui: auto-installer: use empty string as default fqdn

[Shannon Sterz]

Superseded-by: https://lore.proxmox.com/pdm-devel/20260526113310.289789-1-s.sterz@proxmox.com/

On Fri May 22, 2026 at 4:46 PM CEST, Shannon Sterz wrote:
> to avoid users not setting this value themselves, as otherwise
> "host.example.com" would be set as default fqdn for an answer file
> config.
>
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
>  ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs b/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs
> index f1b443e..64d746f 100644
> --- a/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs
> +++ b/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs
> @@ -55,7 +55,7 @@ impl AddAnswerWizardProperties {
>              target_filter: BTreeMap::new(),
>              // global options
>              country: "at".to_owned(),
> -            fqdn: "host.example.com".to_owned(),
> +            fqdn: String::new(),
>              use_dhcp_fqdn: false,
>              keyboard: answer::KeyboardLayout::default(),
>              mailto: String::new(),