all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Shannon Sterz" <s.sterz@proxmox.com>, <pdm-devel@lists.proxmox.com>
Subject: Re: [PATCH datacenter-manager] ui: auto-installer: use empty string as default fqdn
Date: Tue, 26 May 2026 13:34:28 +0200	[thread overview]
Message-ID: <DISKRN0BXR5I.1T4NALE2PSVYR@proxmox.com> (raw)
In-Reply-To: <20260522144633.475938-1-s.sterz@proxmox.com>

Superseded-by: https://lore.proxmox.com/pdm-devel/20260526113310.289789-1-s.sterz@proxmox.com/

On Fri May 22, 2026 at 4:46 PM CEST, Shannon Sterz wrote:
> to avoid users not setting this value themselves, as otherwise
> "host.example.com" would be set as default fqdn for an answer file
> config.
>
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
>  ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs b/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs
> index f1b443e..64d746f 100644
> --- a/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs
> +++ b/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs
> @@ -55,7 +55,7 @@ impl AddAnswerWizardProperties {
>              target_filter: BTreeMap::new(),
>              // global options
>              country: "at".to_owned(),
> -            fqdn: "host.example.com".to_owned(),
> +            fqdn: String::new(),
>              use_dhcp_fqdn: false,
>              keyboard: answer::KeyboardLayout::default(),
>              mailto: String::new(),





      parent reply	other threads:[~2026-05-26 11:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-22 14:46 [PATCH datacenter-manager] ui: auto-installer: use empty string as default fqdn Shannon Sterz
2026-05-26  9:08 ` Fabian Grünbichler
2026-05-26  9:16   ` Shannon Sterz
2026-05-26 11:34 ` Shannon Sterz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DISKRN0BXR5I.1T4NALE2PSVYR@proxmox.com \
    --to=s.sterz@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal