Re: [PATCH datacenter-manager] ui: auto-installer: use empty string as default fqdn

["Fabian Grünbichler" <f.gruenbichler@proxmox.com>]

On May 22, 2026 4:46 pm, Shannon Sterz wrote:
> to avoid users not setting this value themselves, as otherwise
> "host.example.com" would be set as default fqdn for an answer file
> config.
> 
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
>  ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs b/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs
> index f1b443e..64d746f 100644
> --- a/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs
> +++ b/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs
> @@ -55,7 +55,7 @@ impl AddAnswerWizardProperties {
>              target_filter: BTreeMap::new(),
>              // global options
>              country: "at".to_owned(),
> -            fqdn: "host.example.com".to_owned(),
> +            fqdn: String::new(),

this looks okay to me, though I wonder whether it wouldn't be better to
either default to

>              use_dhcp_fqdn: false,

this, or use the placeholder with the template vars as default value but
do not accept it as valid?

>              keyboard: answer::KeyboardLayout::default(),
>              mailto: String::new(),
> -- 
> 2.47.3
> 
> 
> 
> 
> 
>