[PATCH manager] ui: vnet edit: disable tag and vlan aware fields instead of hiding them

[PATCH manager] ui: vnet edit: disable tag and vlan aware fields instead of hiding them

[Shannon Sterz]

this improves ux as users unfamiliar with the ui can now tell that
this would be the correct place to set these values, even if the
currently select zone does not support them. particularly important
when creating new vnets, where the controller type is not yet selected
and both fields would be hidden at first.

Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
 www/manager6/sdn/VnetEdit.js | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/www/manager6/sdn/VnetEdit.js b/www/manager6/sdn/VnetEdit.js
index 34e382c72..f3d66ce9c 100644
--- a/www/manager6/sdn/VnetEdit.js
+++ b/www/manager6/sdn/VnetEdit.js
@@ -101,18 +101,18 @@ Ext.define('PVE.sdn.VnetInputPanel', {
 
         let tagField = me.down('#sdnVnetTagField');
         if (!zoneType || zoneType === 'simple') {
-            tagField.setVisible(false);
+            tagField.setDisabled(true);
             tagField.setValue('');
         } else {
-            tagField.setVisible(true);
+            tagField.setDisabled(false);
         }
 
         let vlanField = me.down('#sdnVnetVlanAwareField');
         if (!zoneType || zoneType === 'evpn') {
-            vlanField.setVisible(false);
+            vlanField.setDisabled(true);
             vlanField.setValue('');
         } else {
-            vlanField.setVisible(true);
+            vlanField.setDisabled(false);
         }
     },
 });
-- 
2.47.3

applied: [PATCH manager] ui: vnet edit: disable tag and vlan aware fields instead of hiding them

[Thomas Lamprecht]

On Tue, 19 May 2026 14:37:41 +0200, Shannon Sterz wrote:
> this improves ux as users unfamiliar with the ui can now tell that
> this would be the correct place to set these values, even if the
> currently select zone does not support them. particularly important
> when creating new vnets, where the controller type is not yet selected
> and both fields would be hidden at first.
> 
> 
> [...]

Applied, but the hide -> disable change shifts the form-submit behavior subtly:
ExtJS skips disabled fields in getSubmitData, so the setValue('') no longer
triggers the deleteEmpty cbind and editing an existing vnet between zones with
different field support fails with the backend rejecting the now-stale value
(e.g. switching from a vlan zone to simple 400s on the leftover tag). Pushed a
follow-up on top that stages an explicit delete for disabled fields in
onGetValues.

While at it pushed a second one to toggle tag.allowBlank dynamically per the
zone plugin constraints (required on vlan/vxlan/evpn, optional on qinq/faucet)
so the UI flags a missing tag locally instead of round- tripping to the API,
that one was pre-existing though.

Thanks!

[1/1] ui: vnet edit: disable tag and vlan aware fields instead of hiding them
      commit: b8448f3981e7f39f6b6057d7309f8bcac9503890