From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 3C21E1FF13B for ; Wed, 20 May 2026 09:42:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F3A281B075; Wed, 20 May 2026 09:42:41 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 20 May 2026 09:42:07 +0200 Message-Id: To: "Thomas Lamprecht" , Subject: Re: applied: [PATCH manager] ui: vnet edit: disable tag and vlan aware fields instead of hiding them X-Mailer: aerc 0.20.0 References: <20260519123741.210988-1-s.sterz@proxmox.com> <177921827051.2471084.921508220258463184.b4-ty@b4> In-Reply-To: <177921827051.2471084.921508220258463184.b4-ty@b4> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779262912729 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.113 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: QORABSIKN4S3UECCKK5SJCITQMPFGDQX X-Message-ID-Hash: QORABSIKN4S3UECCKK5SJCITQMPFGDQX X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue May 19, 2026 at 9:17 PM CEST, Thomas Lamprecht wrote: > On Tue, 19 May 2026 14:37:41 +0200, Shannon Sterz wrote: >> this improves ux as users unfamiliar with the ui can now tell that >> this would be the correct place to set these values, even if the >> currently select zone does not support them. particularly important >> when creating new vnets, where the controller type is not yet selected >> and both fields would be hidden at first. >> >> >> [...] > > Applied, but the hide -> disable change shifts the form-submit behavior s= ubtly: > ExtJS skips disabled fields in getSubmitData, so the setValue('') no long= er > triggers the deleteEmpty cbind and editing an existing vnet between zones= with > different field support fails with the backend rejecting the now-stale va= lue > (e.g. switching from a vlan zone to simple 400s on the leftover tag). Pus= hed a > follow-up on top that stages an explicit delete for disabled fields in > onGetValues. > > While at it pushed a second one to toggle tag.allowBlank dynamically per = the > zone plugin constraints (required on vlan/vxlan/evpn, optional on qinq/fa= ucet) > so the UI flags a missing tag locally instead of round- tripping to the A= PI, > that one was pre-existing though. > > Thanks! thanks for catching that and sorry i missed the submit behavior changes! > [1/1] ui: vnet edit: disable tag and vlan aware fields instead of hiding = them > commit: b8448f3981e7f39f6b6057d7309f8bcac9503890