all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Shannon Sterz <s.sterz@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager] ui: vnet edit: disable tag and vlan aware fields instead of hiding them
Date: Tue, 19 May 2026 14:37:41 +0200	[thread overview]
Message-ID: <20260519123741.210988-1-s.sterz@proxmox.com> (raw)

this improves ux as users unfamiliar with the ui can now tell that
this would be the correct place to set these values, even if the
currently select zone does not support them. particularly important
when creating new vnets, where the controller type is not yet selected
and both fields would be hidden at first.

Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
 www/manager6/sdn/VnetEdit.js | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/www/manager6/sdn/VnetEdit.js b/www/manager6/sdn/VnetEdit.js
index 34e382c72..f3d66ce9c 100644
--- a/www/manager6/sdn/VnetEdit.js
+++ b/www/manager6/sdn/VnetEdit.js
@@ -101,18 +101,18 @@ Ext.define('PVE.sdn.VnetInputPanel', {
 
         let tagField = me.down('#sdnVnetTagField');
         if (!zoneType || zoneType === 'simple') {
-            tagField.setVisible(false);
+            tagField.setDisabled(true);
             tagField.setValue('');
         } else {
-            tagField.setVisible(true);
+            tagField.setDisabled(false);
         }
 
         let vlanField = me.down('#sdnVnetVlanAwareField');
         if (!zoneType || zoneType === 'evpn') {
-            vlanField.setVisible(false);
+            vlanField.setDisabled(true);
             vlanField.setValue('');
         } else {
-            vlanField.setVisible(true);
+            vlanField.setDisabled(false);
         }
     },
 });
-- 
2.47.3





             reply	other threads:[~2026-05-19 12:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-19 12:37 Shannon Sterz [this message]
2026-05-19 19:17 ` applied: [PATCH manager] ui: vnet edit: disable tag and vlan aware fields instead of hiding them Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260519123741.210988-1-s.sterz@proxmox.com \
    --to=s.sterz@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal