From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>, yew-devel@lists.proxmox.com
Subject: Re: [PATCH yew-comp] wizard: fix page unlocking with advanced fields
Date: Thu, 28 May 2026 12:20:45 +0200 [thread overview]
Message-ID: <2931a660-6cbf-4b24-81f2-358f0010ed2e@proxmox.com> (raw)
In-Reply-To: <20260528091851.1424576-1-d.csapak@proxmox.com>
Am 28.05.26 um 11:18 schrieb Dominik Csapak:
> The wizard depends on the form context validation of the pages to
> determine which to lock and unlock. Initially all pages are locked and
> only if the form_ctx changes and is valid the corresponding page will be
> unlocked. With the introduction of the advanced button in the wizard,
> this can happen for pages even if they're not rendered yet.
I.e., pages get unlocked overly eagerly vs. kept beeing locked? Just to be
sure as the subject confused me there for a moment.
Maybe "fix page validation with advanced fields" as that's what's fixed,
the unlocking is then just an effect of that (can edit that on applying).
FWIW, for the auto installer answer file wizard I'd like to add a
"free_navigation" option to the wizard, with that then one can navigate
through all steps freely from the start. Needs validity handling on submit
and a small UI hint for invalid tabs in the bar for UX though, which is a bit
more work and that's why I skipped adding it yesterday.
Just mentioning for context, your patch here is still warranted in any case.
next prev parent reply other threads:[~2026-05-28 10:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-28 9:18 [PATCH yew-comp] wizard: fix page unlocking with advanced fields Dominik Csapak
2026-05-28 10:20 ` Thomas Lamprecht [this message]
2026-05-28 10:55 ` Dominik Csapak
2026-05-28 11:15 ` Thomas Lamprecht
2026-05-28 11:17 ` applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2931a660-6cbf-4b24-81f2-358f0010ed2e@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=yew-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox