From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 830CE1FF13C for ; Thu, 28 May 2026 12:20:49 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 32900126E1; Thu, 28 May 2026 12:20:49 +0200 (CEST) Message-ID: <2931a660-6cbf-4b24-81f2-358f0010ed2e@proxmox.com> Date: Thu, 28 May 2026 12:20:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH yew-comp] wizard: fix page unlocking with advanced fields To: Dominik Csapak , yew-devel@lists.proxmox.com References: <20260528091851.1424576-1-d.csapak@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <20260528091851.1424576-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779963617754 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.005 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: EBVVBDKZVNR4RFZAI74W7XURXDOBNFG2 X-Message-ID-Hash: EBVVBDKZVNR4RFZAI74W7XURXDOBNFG2 X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Yew framework devel list at Proxmox List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 28.05.26 um 11:18 schrieb Dominik Csapak: > The wizard depends on the form context validation of the pages to > determine which to lock and unlock. Initially all pages are locked and > only if the form_ctx changes and is valid the corresponding page will be > unlocked. With the introduction of the advanced button in the wizard, > this can happen for pages even if they're not rendered yet. I.e., pages get unlocked overly eagerly vs. kept beeing locked? Just to be sure as the subject confused me there for a moment. Maybe "fix page validation with advanced fields" as that's what's fixed, the unlocking is then just an effect of that (can edit that on applying). FWIW, for the auto installer answer file wizard I'd like to add a "free_navigation" option to the wizard, with that then one can navigate through all steps freely from the start. Needs validity handling on submit and a small UI hint for invalid tabs in the bar for UX though, which is a bit more work and that's why I skipped adding it yesterday. Just mentioning for context, your patch here is still warranted in any case.