* [yew-devel] [PATCH proxmox-yew-widget-toolkit 1/1] space: fix space calculation for pwt units
@ 2025-01-30 18:29 Stefan Hanreich
2025-01-31 8:10 ` [yew-devel] applied: " Dietmar Maurer
2025-01-31 9:31 ` [yew-devel] " Thomas Lamprecht
0 siblings, 2 replies; 4+ messages in thread
From: Stefan Hanreich @ 2025-01-30 18:29 UTC (permalink / raw)
To: yew-devel
The px here is unnecessary and causes the calc expression to be
invalid. Since pwt-spacer-base-width is already defined in px we can
simply remove it.
Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
src/props/pwt_space.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/props/pwt_space.rs b/src/props/pwt_space.rs
index 6ea6cd4..c829796 100644
--- a/src/props/pwt_space.rs
+++ b/src/props/pwt_space.rs
@@ -13,7 +13,7 @@ pub enum PwtSpace {
impl std::fmt::Display for PwtSpace {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> Result<(), std::fmt::Error> {
match self {
- PwtSpace::Pwt(v) => write!(f, "calc({v} * var(--pwt-spacer-base-width))px"),
+ PwtSpace::Pwt(v) => write!(f, "calc({v} * var(--pwt-spacer-base-width))"),
PwtSpace::Px(v) => write!(f, "{v}px"),
PwtSpace::Em(v) => write!(f, "{v}em"),
PwtSpace::Fraction(v) => write!(f, "{}%", v * 100.0),
--
2.39.5
_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* [yew-devel] applied: [PATCH proxmox-yew-widget-toolkit 1/1] space: fix space calculation for pwt units
2025-01-30 18:29 [yew-devel] [PATCH proxmox-yew-widget-toolkit 1/1] space: fix space calculation for pwt units Stefan Hanreich
@ 2025-01-31 8:10 ` Dietmar Maurer
2025-01-31 9:31 ` [yew-devel] " Thomas Lamprecht
1 sibling, 0 replies; 4+ messages in thread
From: Dietmar Maurer @ 2025-01-31 8:10 UTC (permalink / raw)
To: Yew framework devel list at Proxmox, Stefan Hanreich
applied
_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [yew-devel] [PATCH proxmox-yew-widget-toolkit 1/1] space: fix space calculation for pwt units
2025-01-30 18:29 [yew-devel] [PATCH proxmox-yew-widget-toolkit 1/1] space: fix space calculation for pwt units Stefan Hanreich
2025-01-31 8:10 ` [yew-devel] applied: " Dietmar Maurer
@ 2025-01-31 9:31 ` Thomas Lamprecht
2025-01-31 9:33 ` Stefan Hanreich
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Lamprecht @ 2025-01-31 9:31 UTC (permalink / raw)
To: Yew framework devel list at Proxmox, Stefan Hanreich
Am 30.01.25 um 19:29 schrieb Stefan Hanreich:
> The px here is unnecessary and causes the calc expression to be
> invalid. Since pwt-spacer-base-width is already defined in px we can
> simply remove it.
Was anything actually broken, or how did you notice this?
_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [yew-devel] [PATCH proxmox-yew-widget-toolkit 1/1] space: fix space calculation for pwt units
2025-01-31 9:31 ` [yew-devel] " Thomas Lamprecht
@ 2025-01-31 9:33 ` Stefan Hanreich
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Hanreich @ 2025-01-31 9:33 UTC (permalink / raw)
To: Thomas Lamprecht, Yew framework devel list at Proxmox
On 1/31/25 10:31, Thomas Lamprecht wrote:
> Am 30.01.25 um 19:29 schrieb Stefan Hanreich:
>> The px here is unnecessary and causes the calc expression to be
>> invalid. Since pwt-spacer-base-width is already defined in px we can
>> simply remove it.
>
> Was anything actually broken, or how did you notice this?
noticed it with a DataTable and trees, where levels > 2 would have no
indentation (should've included it in the commit msg, sorry)
_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-01-31 9:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-01-30 18:29 [yew-devel] [PATCH proxmox-yew-widget-toolkit 1/1] space: fix space calculation for pwt units Stefan Hanreich
2025-01-31 8:10 ` [yew-devel] applied: " Dietmar Maurer
2025-01-31 9:31 ` [yew-devel] " Thomas Lamprecht
2025-01-31 9:33 ` Stefan Hanreich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox