Re: [PATCH proxmox 11/29] notify: matcher: add expression support

[Arthur Bied-Charreton <a.bied-charreton@proxmox.com>]

On Thu, Jul 09, 2026 at 01:56:58PM +0200, Lukas Wagner wrote:
> This commit adds support for the new 'expression' parameter in the
> matcher configuration. It contains a JSON-serialized match expression
> (based on the new proxmox-match-expression crate). It is intended as a
> replacement for the existing match-field, match-calendar,
> match-severity, mode and invert-match keys.
> 
> The match expression implements a strict superset of the existing
> configuration keys, any existing configuration can be converted into
> an expression.
> 
> Expressions lift some of limitations of the old approach, namely they
> allow arbitrary nesting of match rules and combinators.
> 
> The following expressions are supported
>   - all-of (corresponds to the former mode 'all')
>   - any-of (corresponds to the former mode 'any')
>   - one-of (new)
>   - not    (corresponds to former 'invert-match')
>   - match-calendar (unchanged)
>   - match-field    (unchanged)
>   - match-severity (unchanged)
> 
> The combinators all-of, any-of and one-of support an arbitrary number of
> child expressions (where each child can be a combinator, not, or a
> match-* expression).
> 
> Internally, existing, 'old-style' matchers are converted on the fly to
> expressions, meaning there is only a single code path for the matching
> logic. If any matcher has any of the old configuration keys and the new
> expression set, the old keys will be ignored and a warning will be
> logged.
> 
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
one general thing i noticed while testing: it would be really useful to
know which matchers matched a notification. right now the only log
message you get is "notified via target {target}". such a change might
be a better fit in the notification history you have planned though.

another idea (bit more involved ^^): being able to construct test
notifications in the UI and showing a list of matching matchers. 

(not particularly relevant to this specific patch, just thought about
this while reading it)
> ---
>  Cargo.toml                               |   1 +
>  proxmox-notify/Cargo.toml                |   2 +
>  proxmox-notify/src/matcher/expression.rs |  84 ++++++++++++++
>  proxmox-notify/src/matcher/field.rs      |  31 +++--
>  proxmox-notify/src/matcher/mod.rs        | 142 +++++++++++++----------
>  proxmox-notify/src/matcher/severity.rs   |   6 +-
>  6 files changed, 185 insertions(+), 81 deletions(-)
>  create mode 100644 proxmox-notify/src/matcher/expression.rs
> 
[...]