Re: [PATCH common/manager/network/proxmox-widget-toolkit 0/4] Extend prefix-list CIDR range

[Gabriel Goller <g.goller@proxmox.com>]

On 13.05.2026 00:09, Thomas Lamprecht wrote:
> On 12/05/2026 13:20, Gabriel Goller wrote:
> > This is a follow-up on the route-maps and prefix-list series by Stefan.
> > The goal is to extend the CIDR range on the prefix-list, making it possible to
> > allow prefixes such as 0.0.0.0/0, which is a classic "allow-all".
> > 
> > The current IP64CIDRAddress(ui)/CIDR(api) format only allows a minimum of /8 CIDR. In order
> > to keep it backwards compatible and avoid accidentally breaking migration or
> > replication, create a new format.
> 
> ack, but putting it into common and widget toolkit has a strong YAGNI
> smell and makes it harder to roll out without any real benefit.
> 
> For anything not really generic or when one already knows that it will
> be more widely used I'd prefer putting it as close as possible to the
> leaf nodes that actually use it in the package dependency tree, moving
> them up to a more central dependency is always possible, and can be
> much better judged then with an actual use case in mind (e.g., to a
> minimal libpve-network-types-perl package, so that it can still live
> in pve-network but used basically everywhere).
> 
> Here I'd rather start out with adding the format directly in
> pve-network for the backend JSON schema one and pve-manager's
> www/manager6/Toolkit.js for the UI ones.

Ack, thanks for the review.
Sent a new version:
https://lore.proxmox.com/pve-devel/20260513083430.63529-1-g.goller@proxmox.com/