From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Gabriel Goller <g.goller@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH common/manager/network/proxmox-widget-toolkit 0/4] Extend prefix-list CIDR range
Date: Wed, 13 May 2026 00:09:38 +0200 [thread overview]
Message-ID: <853b8b2a-eefd-4d00-a8da-c92d03bc370e@proxmox.com> (raw)
In-Reply-To: <20260512112129.224619-1-g.goller@proxmox.com>
On 12/05/2026 13:20, Gabriel Goller wrote:
> This is a follow-up on the route-maps and prefix-list series by Stefan.
> The goal is to extend the CIDR range on the prefix-list, making it possible to
> allow prefixes such as 0.0.0.0/0, which is a classic "allow-all".
>
> The current IP64CIDRAddress(ui)/CIDR(api) format only allows a minimum of /8 CIDR. In order
> to keep it backwards compatible and avoid accidentally breaking migration or
> replication, create a new format.
ack, but putting it into common and widget toolkit has a strong YAGNI
smell and makes it harder to roll out without any real benefit.
For anything not really generic or when one already knows that it will
be more widely used I'd prefer putting it as close as possible to the
leaf nodes that actually use it in the package dependency tree, moving
them up to a more central dependency is always possible, and can be
much better judged then with an actual use case in mind (e.g., to a
minimal libpve-network-types-perl package, so that it can still live
in pve-network but used basically everywhere).
Here I'd rather start out with adding the format directly in
pve-network for the backend JSON schema one and pve-manager's
www/manager6/Toolkit.js for the UI ones.
next prev parent reply other threads:[~2026-05-12 22:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 11:21 [PATCH common/manager/network/proxmox-widget-toolkit 0/4] Extend prefix-list CIDR range Gabriel Goller
2026-05-12 11:21 ` [PATCH pve-common 1/4] jsonschema: add full-range CIDR JSON schema formats Gabriel Goller
2026-05-12 11:21 ` [PATCH pve-network 2/4] sdn: prefix-list: allow full prefix CIDR range Gabriel Goller
2026-05-12 11:21 ` [PATCH proxmox-widget-toolkit 3/4] toolkit: Add IP/CIDR validator with full prefix range checks Gabriel Goller
2026-05-12 11:21 ` [PATCH pve-manager 4/4] sdn: prefix-lists: change prefix format to allow bigger subnets Gabriel Goller
2026-05-12 22:09 ` Thomas Lamprecht [this message]
2026-05-13 8:35 ` [PATCH common/manager/network/proxmox-widget-toolkit 0/4] Extend prefix-list CIDR range Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=853b8b2a-eefd-4d00-a8da-c92d03bc370e@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox