* [PATCH manager] ui: vCPU flag selector: add tooltips for acceleration modes
@ 2026-07-28 8:52 Fiona Ebner
2026-07-28 12:05 ` Arthur Bied-Charreton
2026-07-28 12:18 ` Maximiliano Sandoval
0 siblings, 2 replies; 3+ messages in thread
From: Fiona Ebner @ 2026-07-28 8:52 UTC (permalink / raw)
To: pve-devel
Avoid confusion for users who are not familiar with the terms [0].
Especially TCG is not that well-known.
[0]: https://forum.proxmox.com/threads/185360/
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
www/manager6/form/VMCPUFlagSelector.js | 17 +++++++++++++++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js
index aadd8b88..b51731aa 100644
--- a/www/manager6/form/VMCPUFlagSelector.js
+++ b/www/manager6/form/VMCPUFlagSelector.js
@@ -292,8 +292,21 @@ Ext.define('PVE.form.VMCPUFlagSelector', {
xtype: 'segmentedbutton',
allowMultiple: false,
items: [
- { text: 'KVM', value: 1, pressed: true },
- { text: 'TCG', value: 0 },
+ {
+ text: 'KVM',
+ value: 1,
+ pressed: true,
+ tooltip: gettext(
+ 'Hardware-accelerated virtualization (fast, recommended)',
+ ),
+ },
+ {
+ text: 'TCG',
+ value: 0,
+ tooltip: gettext(
+ 'Software emulation (slow, needed for cross-architecture emulation)',
+ ),
+ },
],
listeners: {
change: function (field, value) {
--
2.47.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH manager] ui: vCPU flag selector: add tooltips for acceleration modes
2026-07-28 8:52 [PATCH manager] ui: vCPU flag selector: add tooltips for acceleration modes Fiona Ebner
@ 2026-07-28 12:05 ` Arthur Bied-Charreton
2026-07-28 12:18 ` Maximiliano Sandoval
1 sibling, 0 replies; 3+ messages in thread
From: Arthur Bied-Charreton @ 2026-07-28 12:05 UTC (permalink / raw)
To: Fiona Ebner; +Cc: pve-devel
On Tue, Jul 28, 2026 at 10:52:00AM +0200, Fiona Ebner wrote:
> Avoid confusion for users who are not familiar with the terms [0].
> Especially TCG is not that well-known.
>
> [0]: https://forum.proxmox.com/threads/185360/
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> www/manager6/form/VMCPUFlagSelector.js | 17 +++++++++++++++--
> 1 file changed, 15 insertions(+), 2 deletions(-)
>
> diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js
> index aadd8b88..b51731aa 100644
> --- a/www/manager6/form/VMCPUFlagSelector.js
> +++ b/www/manager6/form/VMCPUFlagSelector.js
> @@ -292,8 +292,21 @@ Ext.define('PVE.form.VMCPUFlagSelector', {
> xtype: 'segmentedbutton',
> allowMultiple: false,
> items: [
> - { text: 'KVM', value: 1, pressed: true },
> - { text: 'TCG', value: 0 },
> + {
> + text: 'KVM',
> + value: 1,
> + pressed: true,
> + tooltip: gettext(
> + 'Hardware-accelerated virtualization (fast, recommended)',
> + ),
> + },
> + {
> + text: 'TCG',
> + value: 0,
> + tooltip: gettext(
> + 'Software emulation (slow, needed for cross-architecture emulation)',
> + ),
> + },
> ],
> listeners: {
> change: function (field, value) {
> --
> 2.47.3
>
>
Thanks for this, good addition and works as advertised.
Reviewed-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
Tested-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH manager] ui: vCPU flag selector: add tooltips for acceleration modes
2026-07-28 8:52 [PATCH manager] ui: vCPU flag selector: add tooltips for acceleration modes Fiona Ebner
2026-07-28 12:05 ` Arthur Bied-Charreton
@ 2026-07-28 12:18 ` Maximiliano Sandoval
1 sibling, 0 replies; 3+ messages in thread
From: Maximiliano Sandoval @ 2026-07-28 12:18 UTC (permalink / raw)
To: Fiona Ebner; +Cc: pve-devel
Fiona Ebner <f.ebner@proxmox.com> writes:
> Avoid confusion for users who are not familiar with the terms [0].
> Especially TCG is not that well-known.
>
> [0]: https://forum.proxmox.com/threads/185360/
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
I had this on my todo-list. lgtm.
Reviewed-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
--
Maximiliano
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-28 12:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-28 8:52 [PATCH manager] ui: vCPU flag selector: add tooltips for acceleration modes Fiona Ebner
2026-07-28 12:05 ` Arthur Bied-Charreton
2026-07-28 12:18 ` Maximiliano Sandoval
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox