Re: [PATCH docs 1/3] close #7204: storage: lvm thin: document that thin pools must have zeroing enabled

[Maximiliano Sandoval <m.sandoval@proxmox.com>]

Fiona Ebner <f.ebner@proxmox.com> writes:

> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>  pve-storage-lvmthin.adoc | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/pve-storage-lvmthin.adoc b/pve-storage-lvmthin.adoc
> index 83f65a3..48505a9 100644
> --- a/pve-storage-lvmthin.adoc
> +++ b/pve-storage-lvmthin.adoc
> @@ -23,6 +23,11 @@ lvcreate -L 100G -n data pve
>  lvconvert --type thin-pool pve/data
>  ----
>  
> +WARNING: The `zero` property for the thin pool must be set or certain operations
> +for VM images may lead to data corruption! The property is controlled via the
> +`allocation/thin_pool_zero` LVM configuration option and is enabled by default.
> +Check with `lvs pve/data -o lv_name,zero` which should indicate `zero` in the

The check here should be generic. Users of the default lvthin setup
(pve/data) are likely to also have the default zero=zero option set.
Perhaps something like:

$ lvs -S 'lv_attr =~ ^t' -o lv_name,zero
  LV   Zero
  data zero

> +output below the `Zero` heading.
>  
>  Configuration
>  ~~~~~~~~~~~~~

-- 
Maximiliano