public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: Maximiliano Sandoval <m.sandoval@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH docs 1/3] close #7204: storage: lvm thin: document that thin pools must have zeroing enabled
Date: Wed, 12 Aug 2026 11:00:05 +0200	[thread overview]
Message-ID: <92d42b4f-debe-4ec8-968f-04d695edf066@proxmox.com> (raw)
In-Reply-To: <s8oqzk3917f.fsf@toolbox>

Am 12.08.26 um 10:45 AM schrieb Maximiliano Sandoval:
> Fiona Ebner <f.ebner@proxmox.com> writes:
> 
>> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
>> ---
>>  pve-storage-lvmthin.adoc | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/pve-storage-lvmthin.adoc b/pve-storage-lvmthin.adoc
>> index 83f65a3..48505a9 100644
>> --- a/pve-storage-lvmthin.adoc
>> +++ b/pve-storage-lvmthin.adoc
>> @@ -23,6 +23,11 @@ lvcreate -L 100G -n data pve
>>  lvconvert --type thin-pool pve/data
>>  ----
>>  
>> +WARNING: The `zero` property for the thin pool must be set or certain operations
>> +for VM images may lead to data corruption! The property is controlled via the
>> +`allocation/thin_pool_zero` LVM configuration option and is enabled by default.
>> +Check with `lvs pve/data -o lv_name,zero` which should indicate `zero` in the
> 
> The check here should be generic. Users of the default lvthin setup
> (pve/data) are likely to also have the default zero=zero option set.
> Perhaps something like:
> 
> $ lvs -S 'lv_attr =~ ^t' -o lv_name,zero
>   LV   Zero
>   data zero
> 

The example above uses pve/data as the thin pool name, so I am just
continuing the example. But yeah, I'll change the check in v2.

>> +output below the `Zero` heading.
>>  
>>  Configuration
>>  ~~~~~~~~~~~~~
> 





  reply	other threads:[~2026-08-12  9:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-05 16:38 [PATCH-SERIES docs/storage 0/3] close #7204: document and check that thin pools have zeroing enabled Fiona Ebner
2026-02-05 16:38 ` [PATCH docs 1/3] close #7204: storage: lvm thin: document that thin pools must " Fiona Ebner
2026-08-12  8:45   ` Maximiliano Sandoval
2026-08-12  9:00     ` Fiona Ebner [this message]
2026-02-05 16:38 ` [RFC storage 2/3] lvm plugin: list volumes: also query 'zero' property Fiona Ebner
2026-02-05 16:38 ` [RFC storage 3/3] close #7204: lvm thin plugin: die if thin pool does not have zeroing configured Fiona Ebner
2026-08-12 10:37   ` Maximiliano Sandoval
2026-08-12  8:26 ` [PATCH-SERIES docs/storage 0/3] close #7204: document and check that thin pools have zeroing enabled Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=92d42b4f-debe-4ec8-968f-04d695edf066@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal