From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: Jonas Theisen <j.theisen@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH pve-manager v3 0/2] fix #8031: write APT proxy config on http_proxy change
Date: Wed, 16 Sep 2026 11:32:03 +0200 [thread overview]
Message-ID: <s8o33v9sfsc.fsf@toolbox> (raw)
In-Reply-To: <20260915091758.85522-1-j.theisen@proxmox.com> (Jonas Theisen's message of "Tue, 15 Sep 2026 11:16:56 +0200")
Jonas Theisen <j.theisen@proxmox.com> writes:
> To allow reuse of the same code this patch series factors out
> the relevant function inside the APT part of the API and reuses
> the function on change of the http_proxy variable in the Cluster API.
>
> This is to ensure a consistent state after a change of the HTTP proxy
> without having to run a Refresh / apt update through the PVE tooling.
>
> https://bugzilla.proxmox.com/show_bug.cgi?id=8031
Looks good to me.
Reviewed-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
--
Maximiliano
prev parent reply other threads:[~2026-09-16 9:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 9:16 [PATCH pve-manager v3 0/2] fix #8031: write APT proxy config on http_proxy change Jonas Theisen
2026-09-15 9:16 ` [PATCH pve-manager v3 1/2] fix #8031: factor out APT proxy write from update_database call Jonas Theisen
2026-09-15 9:16 ` [PATCH pve-manager v3 2/2] fix #8031: write APT proxy config on http_proxy change Jonas Theisen
2026-09-16 9:32 ` Maximiliano Sandoval [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s8o33v9sfsc.fsf@toolbox \
--to=m.sandoval@proxmox.com \
--cc=j.theisen@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox