From: Jonas Theisen <j.theisen@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-manager v3 2/2] fix #8031: write APT proxy config on http_proxy change
Date: Tue, 15 Sep 2026 11:16:58 +0200 [thread overview]
Message-ID: <20260915091758.85522-3-j.theisen@proxmox.com> (raw)
In-Reply-To: <20260915091758.85522-1-j.theisen@proxmox.com>
Writes the necessary file for APT if the http_proxy variable
on the datacenter level is changed.
This reuses the same function from the APT API for a regular
database update.
Signed-off-by: Jonas Theisen <j.theisen@proxmox.com>
---
PVE/API2/Cluster.pm | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/PVE/API2/Cluster.pm b/PVE/API2/Cluster.pm
index 4e5efbfd..efda3906 100644
--- a/PVE/API2/Cluster.pm
+++ b/PVE/API2/Cluster.pm
@@ -36,6 +36,7 @@ use PVE::API2::ClusterConfig;
use PVE::API2::Firewall::Cluster;
use PVE::API2::HAConfig;
use PVE::API2::ReplicationConfig;
+use PVE::API2::APT;
my $have_sdn;
eval {
@@ -842,8 +843,17 @@ __PACKAGE__->register_method({
code => sub {
my ($param) = @_;
+ my $http_proxy_change = 0;
+
my $delete = extract_param($param, 'delete');
+ if (
+ defined($param->{http_proxy})
+ || (defined($delete) && $delete =~ m/\bhttp_proxy\b/)
+ ) {
+ $http_proxy_change = 1;
+ }
+
cfs_lock_file(
'datacenter.cfg',
undef,
@@ -859,6 +869,10 @@ __PACKAGE__->register_method({
);
die $@ if $@;
+ if ($http_proxy_change) {
+ PVE::API2::APT::update_apt_proxy_config();
+ }
+
return undef;
},
});
--
2.47.3
next prev parent reply other threads:[~2026-09-15 9:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 9:16 [PATCH pve-manager v3 0/2] fix #8031: write APT proxy config on http_proxy change Jonas Theisen
2026-09-15 9:16 ` [PATCH pve-manager v3 1/2] fix #8031: factor out APT proxy write from update_database call Jonas Theisen
2026-09-15 9:16 ` Jonas Theisen [this message]
2026-09-16 9:32 ` [PATCH pve-manager v3 0/2] fix #8031: write APT proxy config on http_proxy change Maximiliano Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260915091758.85522-3-j.theisen@proxmox.com \
--to=j.theisen@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox