Re: [PATCH pve-manager v3 2/3] fix #5032: ui: qemu agent: add sync-time-on-resume option

[Maximiliano Sandoval <m.sandoval@proxmox.com>]

Jakob Klocker <j.klocker@proxmox.com> writes:

> Expose the new agent configuration option `sync-time-on-resume`
> in the VM configuration GUI.
>
> This allows enabling/disabling automatic guest clock
> synchronization after clock-stalling operations.
>
> Signed-off-by: Jakob Klocker <j.klocker@proxmox.com>
> ---
> changes since v1:
> - reword the agent option label for clarity
> changes since v2:
> - set default value to disabled
>
>  www/manager6/form/AgentFeatureSelector.js | 18 +++++++++++++++++-
>  1 file changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/www/manager6/form/AgentFeatureSelector.js b/www/manager6/form/AgentFeatureSelector.js
> index 3cae4194..10bb3eeb 100644
> --- a/www/manager6/form/AgentFeatureSelector.js
> +++ b/www/manager6/form/AgentFeatureSelector.js
> @@ -45,6 +45,20 @@ Ext.define('PVE.form.AgentFeatureSelector', {
>                  hidden: '{freeze_fs.checked}',
>              },
>          },
> +        {
> +            xtype: 'proxmoxcheckbox',
> +            boxLabel: gettext(
> +                "Synchronize guest clock with the host's after resume from saved state",

I would say "...after resuming from a previous state".

> +            ),
> +            name: 'sync-time-on-resume',
> +            reference: 'sync_time_on_resume',
> +            bind: {
> +                disabled: '{!enabled.checked}',
> +            },
> +            disabled: true,
> +            uncheckedValue: '0',
> +            defaultValue: '0',
> +        },
>          {
>              xtype: 'displayfield',
>              userCls: 'pmx-hint',
> @@ -74,7 +88,9 @@ Ext.define('PVE.form.AgentFeatureSelector', {
>          if (PVE.Parser.parseBoolean(values['freeze-fs'])) {
>              delete values['freeze-fs'];
>          }
> -
> +        if (!PVE.Parser.parseBoolean(values['sync-time-on-resume'])) {
> +            delete values['sync-time-on-resume'];
> +        }
>          const agentstr = PVE.Parser.printPropertyString(values, 'enabled');
>          return { agent: agentstr };
>      },

-- 
Maximiliano