From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40])
	by lore.proxmox.com (Postfix) with ESMTPS id 7C15C1FF135
	for <inbox@lore.proxmox.com>; Thu, 02 Jul 2026 13:00:38 +0200 (CEST)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id BB875213DD;
	Thu, 02 Jul 2026 13:00:37 +0200 (CEST)
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: Jakob Klocker <j.klocker@proxmox.com>
Subject: Re: [PATCH pve-manager v3 2/3] fix #5032: ui: qemu agent: add
 sync-time-on-resume option
In-Reply-To: <20260702103201.164567-3-j.klocker@proxmox.com> (Jakob Klocker's
	message of "Thu, 2 Jul 2026 12:32:00 +0200")
References: <20260702103201.164567-1-j.klocker@proxmox.com>
	<20260702103201.164567-3-j.klocker@proxmox.com>
User-Agent: mu4e 1.12.9; emacs 30.1
Date: Thu, 02 Jul 2026 13:00:33 +0200
Message-ID: <s8o1pdl7j1q.fsf@toolbox>
MIME-Version: 1.0
Content-Type: text/plain
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1782990027582
X-SPAM-LEVEL: Spam detection results:  0
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: NOTNDH3NGHO6OM5JOPQR2TVFR7MEBIY5
X-Message-ID-Hash: NOTNDH3NGHO6OM5JOPQR2TVFR7MEBIY5
X-MailFrom: m.sandoval@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
CC: pve-devel@lists.proxmox.com
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

Jakob Klocker <j.klocker@proxmox.com> writes:

> Expose the new agent configuration option `sync-time-on-resume`
> in the VM configuration GUI.
>
> This allows enabling/disabling automatic guest clock
> synchronization after clock-stalling operations.
>
> Signed-off-by: Jakob Klocker <j.klocker@proxmox.com>
> ---
> changes since v1:
> - reword the agent option label for clarity
> changes since v2:
> - set default value to disabled
>
>  www/manager6/form/AgentFeatureSelector.js | 18 +++++++++++++++++-
>  1 file changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/www/manager6/form/AgentFeatureSelector.js b/www/manager6/form/AgentFeatureSelector.js
> index 3cae4194..10bb3eeb 100644
> --- a/www/manager6/form/AgentFeatureSelector.js
> +++ b/www/manager6/form/AgentFeatureSelector.js
> @@ -45,6 +45,20 @@ Ext.define('PVE.form.AgentFeatureSelector', {
>                  hidden: '{freeze_fs.checked}',
>              },
>          },
> +        {
> +            xtype: 'proxmoxcheckbox',
> +            boxLabel: gettext(
> +                "Synchronize guest clock with the host's after resume from saved state",

I would say "...after resuming from a previous state".

> +            ),
> +            name: 'sync-time-on-resume',
> +            reference: 'sync_time_on_resume',
> +            bind: {
> +                disabled: '{!enabled.checked}',
> +            },
> +            disabled: true,
> +            uncheckedValue: '0',
> +            defaultValue: '0',
> +        },
>          {
>              xtype: 'displayfield',
>              userCls: 'pmx-hint',
> @@ -74,7 +88,9 @@ Ext.define('PVE.form.AgentFeatureSelector', {
>          if (PVE.Parser.parseBoolean(values['freeze-fs'])) {
>              delete values['freeze-fs'];
>          }
> -
> +        if (!PVE.Parser.parseBoolean(values['sync-time-on-resume'])) {
> +            delete values['sync-time-on-resume'];
> +        }
>          const agentstr = PVE.Parser.printPropertyString(values, 'enabled');
>          return { agent: agentstr };
>      },

-- 
Maximiliano